Tests not compiling if OpenMP not found
Ah, great that you figured it out so quickly. Why do you say that lf_db_load_data should be removed? I actually use this function :) On 09.02.2019 15:24, seebk wrote: Ok, think I got it. The declaration in the header and the implementations do not match. It also looks like some of the C-API functions of lfDatabase are not correct anymore and should be removed. e.g lf_db_load_data() [bugs:#117] https://sourceforge.net/p/lensfun/bugs/117/ Some C API functions not exported on Windows Status: open Created:...
Looks like this also happens on Linux: https://travis-ci.org/letmaik/lensfunpy/jobs/490962742#L1086 Here the effect is delayed as the linker by default allows to build shared libraries with unresolved symbols, so this errors only when actually loading the library.
Some C API functions not exported on Windows
Cannot build master on MSVC (Wformat-security unknown)
Allow to override CMAKE_INSTALL_DATAROOTDIR also on Windows
Adapt FindGLIB2.cmake to work with vcpkg
Works, thanks.
An easy solution would be to use the qualified std::isnan and removing using std::isnan;.
Looks like an issue on older GCC that has been fixed since (roughly >= 6.1 which is April 2016): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48891 https://bugs.webkit.org/show_bug.cgi?id=59249 Webkit's workaround is https://trac.webkit.org/changeset/117779/webkit but I would agree we don't want this kind of heavy machinery. Let me see if there's another solution, apart from forcing gcc >= 6.1.
Compile error: malloc/free used without stdlib.h include in mount.cpp
Compile error with GCC on latest master
Your fix has a syntax error: #if (defined(_MSC_VER) && (_MSC_VER < 1800) There is a parenthesis missing at the end.
Inconsistent default value for lfModifier distance
In fact, this also happens with MSVC 2010: https://ci.appveyor.com/project/letmaik/lensfunpy/build/1.0.210/job/144i8ck8stkominm#L447
Cannot compile on MSVC 2008: stdbool.h missing
Is this still the case or is it now possible to link against libmingwex.a from an MSVC built library?
Ok looks good to me. But since the C wrapper is new, please try not to break the...
I guess so, but this function does not have a C equivalent currently, right?
Well, the fix to the Win/Mac workaround in my library would be that lfDatabase::Load()...
Haha! Those "private" database functions are extremely useful! I think they should...
Oops, right... ok, feel free to close this issue and revert your doc change to the...
Ok, I think I agree, and the underlying issue as you said should probably be solved...
So for the case of "Nikon AF-S Zoom-Nikkor 17-35mm f/2.8D IF-ED" where MinAperture...
I see, ok. Good to know that it's already tracked elsewhere. Please close it.
Mention LF_NO_DATABASE in 0.3.2 release notes
Works, thanks!
About what I have to solve: Well, just semantics. I'm the developer of the python...
The xml doc at http://lensfun.sourceforge.net/manual/el_lens.html looks fine. But...
Well, the actual lens is suitable for FF cameras, right? It's just that the calibration...
Cannot compile 0.3.2 on VS <= 2010
Cannot find lens via lf_db_find_lenses_hd with exact name match
Max aperture is zero when fixed
Great, just tried it with the latest commit and it works. https://travis-ci.org/...
lensfun 0.3.2 broken on Ubuntu 12.04
That did it, thanks. Turns out I actually already do that for Windows, just forgot...
Hm yes, but that's really a shame because it breaks both my Ubuntu 12.04 and Windows...
Build error with 0.3.1 (automated tests) on linux
I am a bit confused by the azimuth output of geographiclib. I use the Python implementation,...
I just tested master merged with mvc-math and compilation went fine. Thanks for the...
The Internet tells me (although I haven't tried it) that recent versions of 7-zip...
My work-around: https://github.com/neothemachine/libjpeg-turbo-vc-binaries/relea...
Ok I didn't know that it's actually more than a self-extracting archive. Does that...
Provide zips instead of exe's
Getting closer, math errors are gone. Now I hit two problems of which I could solve...
Getting closer, math errors are gone. Now I hit two problems of which I could solve...
M_PI and NAN undefined (MSVC)
isfinite not available on MSVC < 2013
This issue can be closed.
There still seems to be a problem with the 64 bit build but I think that's nothing...
I used the command line. Apparently the default is "whatever is installed", on another...
I got it working now, the Makefile produced by cmake is for NMake, so I have to invoke...
I switched to cmake now. It finds glib after I manually define the glib2 dir using...
Problems compiling with MSVC
I'm interested in the same. I need to process the raw Bayer pixels to eliminate hot...
I had a similar issue when I compiled and installed lensfun myself. The problem is...