Activity for Mehmet Avcioglu
-
Mehmet Avcioglu posted a comment on ticket #98
Hello @LiverpoolFCfan, trying to upgrade our setup to 73 I had a chance to invastigate this further. Looks like you implemented the new option on line 6256, but mb_detect_encoding is also used on lines 6408 and 6624, and in these two cases still fails on php 8.1 and 8.2. versions. It is also possible to limit the php version check to specifically 8.1 and 8.2 instead of bigger than 8.0, but that is up to you.
-
Yes agreed, the behaviour of mb_detect_encoding has reverted back to the documented state with php 8.3. The example I had previously given above also shows it fixed on php 8.3 versions https://3v4l.org/C2rkJ. What to do now? Perhaps adding a version check and defaulting for the alternative method on php 8.1/8.2 versions might be an option. Not sure how you feel about leaving the ZIMBRA_USE_MB_CHECK_ENCODING setting?
-
Hello @liverpoolfcfan sorry I have been busy. There seems to be a missunderstanding on my part, I am not seing the point in your proposed tests, if internal encoding is UTF-8 and mb_convert_encoding is run without from_encoding then it will simply not do anything. Also all our environments are UTF-8 this forum, web sites that I can copy sample text from, etc. are probably all UTF-8. What we need to test is the case where some end user client is sending out text in other character sets, which we cannot...
-
Yes, as mentioned before, the code is trying to detect the encoding and in order to stay at UTF-8, if it is already UTF-8, it needs to work in order of the encodings given, because we don't want to convert something that is already UTF-8. Php8.1 version of mb_detect_enconding method looks at the bytes and not their character shape representations, so something that looks in shape a correct URF-8 string internally matches to ISO-8859-9. mb_detect_encoding_in_order method given above tries to do, in...
-
@liverpoolfcfan php8.1 implementation of mb_detect_encoding no longer works in order. The php.net documentation and examples given there are also incorrect. The example given on php.net to explain the in order characteristics of the function is the below code, coppied from https://www.php.net/mb_detect_encoding (it may be fixed by the time you are looking at it, there is an open issue to fix the documentation also) <?php $str = "\xC4\xA2"; // The string is valid in all three encodings, so the first...
-
Hello @liverpoolfcfan First of all, my condolences on Saturday's match. I was rooting for Liverpool, they played the better game, but the other side is just so efficient in winning it is almost ugly. We tested Contacts, Emailed Contacts, GAL search, and GAL sync (with shared GAL folder) with Windows Outlook, Android Outlook, Android Gmail, IOS, and IOS Outlook as well as IOS CardDav. After the 71.1 update experiences are similar between these products, with the exception of Windows Outlook not performing...
-
GAL by default works for searching as you explained, but also configuring GAL on Zimbra creates a contact list share. It is common behavior for users to add that share to their account which shows GAL as a folder on their account and that folder displays distribution lists if they are not hidden from GAL. I am attaching screen shots. If we remove group typed items from contacts the contents of this folder on Zimbra user interface and synced devices differs. Thanks.
-
GAL by default works for searching as you explained, but also configuring GAL on Zimbra creates a contact list share. It is common behavior for users to add that share to their account which shows GAL as a folder on their account and that folder displays distribution lists if they are not hidden from GAL. I am attaching screen shots. If we remove group typed items from contacts the contents of this folder on Zimbra user interface and synced devices differs. Thanks.
-
GAL by default works for searching as you explained, but also configuring GAL on Zimbra creates a contact list share. It is common behavior for users to add that share to their account which shows GAL as a folder on their account and that folder displays distribution lists if they are not hidden from GAL. I am attaching screen shots. Thanks.
-
GAL by default works for searching as you explained, but also configuring GAL on Zimbra creates a contact list share. It is common behavior for users to add that share to their account which shows GAL as a folder on their account and that folder displays distribution lists if they are not hidden from GAL. I am attaching screen shots to show this. Thanks.
-
GAL by default works for searching as you explained, but also configuring GAL on Zimbra creates a contact list share. It is common behavior for users to add that share to their account which shows GAL as a folder on their account and that folder displays distirbution lists if they are not hidden from GAL. I am attaching screen shots to show this. Thanks.
-
I understand what you are saying, and yes the attributes are different, but GAL is a read only folder and the admin by deselecting "Hide in GAL" has opted to show the e-mail address of the distribution list inside that folder (albeit without a name, phone number, company, etc.). GAL can also be generated from external sources like LDAP/AD servers. Similarly e-mail addresses that happen to match the given ldap query will appear in GAL. I think the expectation is to see on the synced device whatever...
-
Hello @liverpoolfcfan Yes, we had also noticed the IOS search feature missing some distribution lists and the 71.1 fix seems to have fixed that. Thank you. The unrelated issue is that GAL sync omits items with type group. After reading your comment I understand that there are also "groups" created by individual users and they need to be ommit, but this also omits distribution lists in GAL which also have group as their ['_attrs']['type']. Distribution list: { "id": "e8b3d70d-3dd7-4517-a928-9a62be8de370:355",...
-
Hello @liverpoolfcfan Yes, we had also noticed the IOS search feature missing some distribution lists and the 71.1 fix seems to have fixed that. Thank you. The unrelated issue is that GAL sync omits items with type group. After reading your comment I understand that there are also groups created by individual users and they need to be ommit, but this also omits distribution lists in GAL which also have group as their ['_attrs']['type']. Distribution list: { "id": "e8b3d70d-3dd7-4517-a928-9a62be8de370:355",...
-
It may be possible to add an option such as ZIMBRA_IGNORE_CONTACT_GROUPS similar to ZIMBRA_IGNORE_EMAILED_CONTACTS. Here is a patch that does that. --- zimbra.php.old 2022-05-11 12:53:33.248401331 +0300 +++ zimbra.php.new 2022-05-11 13:04:09.123592470 +0300 @@ -112,6 +112,9 @@ * === To prevent sync of the "emailed contacts" folder * define('ZIMBRA_IGNORE_EMAILED_CONTACTS',true); * +* === To prevent sync of groups in contacts +* define('ZIMBRA_IGNORE_CONTACT_GROUPS',true); +* * === To enable HTML...
-
It may be possible to add an option such as ZIMBRA_IGNORE_CONTACT_GROUPS similar to ZIMBRA_IGNORE_EMAILED_CONTACTS. Here is a patch that does that. Here is a patch --- zimbra.php.old 2022-05-11 12:53:33.248401331 +0300 +++ zimbra.php.new 2022-05-11 13:04:09.123592470 +0300 @@ -112,6 +112,9 @@ * === To prevent sync of the "emailed contacts" folder * define('ZIMBRA_IGNORE_EMAILED_CONTACTS',true); * +* === To prevent sync of groups in contacts +* define('ZIMBRA_IGNORE_CONTACT_GROUPS',true); +* * ===...
-
php8 gives en error for line 214 on /backend/zimbra/z_RTF.php $flags = ($flagCount++ % 8 == 0) ? ord($src{$in++}) : $flags >> 1; Compile Error: Array and string offset access syntax with curly braces is no longer supported I don't think this works in earlier versions of php either by the way, just doesn't give an error.
-
Is this really fixed? Running phpMyAdmin-4.2.2 with nginx and php-fpm, it generates...
1
