Activity for Christian Schmitz
-
Christian Schmitz posted a comment on ticket #344
Sorry, we'll update.
-
We got a crash report with ZBarcode_Encode crashing with a stack overflow. Maybe you fixed it already in a newer version, but I would recommend to check against ZINT_MAX_DATA_LEN. I added such a check to the function for our copy of the source code. There is no reason why it should accept 2 MB.
-
Version was Zint 2.9.2
-
ZBarcode_Encode crashes if passed too much data
-
Looks like you didn't fix it for multi frame images. Or did I misunderstand the code? if (comments) { (void) SetImageAttribute(image,"comment",NULL); (void) SetImageAttribute(image,"comment",comments); } this block is on the bottom. But this must go up to where the image is read. The key thing is that we have a GIF with 8 frames. Each frame has a comment. So we have 8 comments and 8 images and I think we need to read each image comment. since not each image has a comment, you also need to set comments...
-
Thank you. That was quick!
-
To fix this, I made comments a variable before the loop: char *comments = (char *) NULL; then when reading the comment, we just store it: comments=comments_new; later when we read the GIF frame, we add the comment: if (comments) { (void) SetImageAttribute(image,"comment",comments); MagickFreeResourceLimitedMemory(comments); comments = NULL; } and on the end, we need to free comments, if it is still there if (comments) { (void) SetImageAttribute(image,"comment",comments); MagickFreeResourceLimitedMemory(comments);...
-
Reading multiple GIFs doesn't read the comments correctly.
-
Sorry, I forgot what it was. Maybe next time I rebuild it here for all 15 platforms, I may just not do the change and see which one it was.
-
Add Quantum casts for 16-bit to Image.cpp and Color.cpp
-
and we rebuilt Scintilla with that change and it works nice now.
-
Correction: The right level is NSPopUpMenuWindowLevel, since that is above the NSModalPanelWindowLevel for the dialogs.
-
NSFloatingWindowLevel vs NSSubmenuWindowLevel
-
malloc error with qr_code_data_list_extract_text
-
We changed the project to build a static library. The info bar can work fine without the image. For my project, I include the images, but I don't like it to crash if the user forgets the pictures.
-
Because we build a library, which others use and they may not include the images. And the software should in my opinion simply work without them.
-
Sure. I use it to build myself a library. And if the waitCursor/reverseArrowCursor would not be static, we could just prefill them on application start.
-
Well, we like to use Scintilla in our app and I'd like to make sure that the images are optional, so this can work without them. So please include a fallback for that case like the two lines above..
-
Since ARC is used, the retain is not needed: + (void) initialize { if (self == [ScintillaView class]) { NSBundle *bundle = [NSBundle bundleForClass: [ScintillaView class]]; NSString *path = [bundle pathForResource: @"mac_cursor_busy" ofType: @"tiff" inDirectory: nil]; NSImage *image = [[NSImage alloc] initWithContentsOfFile: path]; if (image) { waitCursor = [[NSCursor alloc] initWithImage: image hotSpot: NSMakePoint(2, 2)]; } else { NSLog(@"Wait cursor is invalid."); // MBS fix waitCursor = [NSCursor...
-
Since ARC is used, the retain is not needed: + (void) initialize { if (self == [ScintillaView class]) { NSBundle *bundle = [NSBundle bundleForClass: [ScintillaView class]]; NSString *path = [bundle pathForResource: @"mac_cursor_busy" ofType: @"tiff" inDirectory: nil]; NSImage *image = [[NSImage alloc] initWithContentsOfFile: path]; if (image) { waitCursor = [[NSCursor alloc] initWithImage: image hotSpot: NSMakePoint(2, 2)]; } else { NSLog(@"Wait cursor is invalid."); // MBS fix waitCursor = [NSCursor...
-
Avoid crash when cursor images are missing.
-
And it fails because of the line [currentCursors addObject: reverseArrowCursor]; in [SCIMarginView initWithScrollView:], since the reverseArrowCursor was nil for me. And now I look why this happens.
-
Change for ScintillaView.dealloc to fix possible crash
-
Thanks. I see it now.
-
The commit doesn't have a change!?
1
