Matthieu Labas

Fix for memory leak in sxmlc.c

Nice (sort of ;))! I've applied the patch to create the v4.5.4. Thanks!

Awesome, thanks Damian! It feels really rewarding to see that this small project is actually helping people develop bigger things :) I checked out your xlsx_drone project, it seems to be something I could be working with. I especially love the very few files it needs (I guess you noticed it from sxmlc as well ;)). Also, although sxmlc staerted on SourceForge, it is on GitHub as well, in case it's easier to link to: https://github.com/matthieu-labas/sxmlc Thanks again for letting me know, I hope you...

Thank Damian for the update. The UTF-8 part was extensively tested by "hundreds of (external) tests" (from what I was told) so I should be confident that it should be working fine, but you how bugs like to nest in the most hidden places ;) Happy New Year! :) Matthieu

Thank Damian for the update. The UTF-8 part was extensively tested by "hundredth of (external) tests" (from what I was told) so I should be confident that it should be working fine, but you how bugs like to nest in the most hidden places ;) Happy New Year! :) Matthieu

Hello Damian, The difference when compiling with SXMLC_UNICODE is that the file (if you're parsing files, not buffers) is opened in binary mode (fopen("rb")) and all string functions (strdup(), strlen(), etc.) assume wide char instead of char. So maybe if there are characters that must be stored on more than one byte, it could overflow some buffer. We can consider the following: multi-byte characters are never null (see https://unicodebook.readthedocs.io/unicode_encodings.html) so non-SXMLC_UNICODE...

Empty XML file causing segmentation fault

OK thanks. I changed the macro to check for the i_root validity and retur NULL if < 0. I pushed the changes to v4.3.4.