Activity for Martin Dufour
-
Martin Dufour posted a comment on merge request #9
I can't figure out how to make your last improvement work, so I will indeed let you make that final change. Do I understand that GitHub is the preferred channel for code contributions?
-
This merge request is now up-to-date with the corrections.
-
[bugs:#636] Fixed: DTD declaration is replaced with DTD file content in translated document
-
I haven't touched Java code in decades, so I'm grateful for the thorough code review. About Handler.localizeSystemId: swallowing IllegalArgumentException is in line with the previous behavior: if the path can't be relativized, the absolute path is preserved without any fuss. It is not an actual error case. As for the extra condition in doEndEntity, this is due to my decoupling of extEntity and extWriter in doResolve; this corrects the behavior when referring to an extEntity that is in a parent directory...
-
Done; let me know if you'd like more details about the included changes!
-
[bugs:#636] Fixed: DTD declaration is replaced with DTD file content in translated document
-
Thanks! Shall I recreate the merge request with the corrected ticket mention in the commit message?
-
Looks like sourceforge is linking to an unrelated feature request; the bug in question here is https://sourceforge.net/p/omegat/bugs/636/.
-
[#636] Fixed: DTD declaration is replaced with DTD file content in translated document
-
[#636] Fixed: DTD declaration is replaced with DTD file content in translated document
-
Fix PdfFilter test failure on Windows (EOL difference)
-
Fix PdfFilter test failure on Windows (EOL difference)
-
I have a similar issue with DocBook files that use this pattern to externally define shared entities across files: <!DOCTYPE book [ <!ENTITY % myent SYSTEM "/path/to/myentities.ent"> %myent; ]> The entity declarations from myentities.ent get inlined right after the SYSTEM entity. I can prevent this behavior by commenting out this source line in Handler.java: public void internalEntityDecl(String name, String value) throws SAXException { if (inDTD) { return; } Entity entity = new Entity(name, value);...
1