label-alignments for VoltaBrackets and line spanners, changes entry http://codereview.appspot.com/575330043
tuplet-number.cc has a workaround for a similar issue but I think instead of workarounds for other grobs we need a solution coming from the stems/beams themselves.
Improve positioning of rehearsal marks at the beginning of staff
Improve positioning of rehearsal marks at the beginning of staff
add suggestAccidentals = #'cautionary option
commit 28e08cc4c2774752d3aa362464b6b0e56c61e834 Author: Malte Meyn lilypond@maltemeyn.de Date: Sat Nov 23 12:24:12 2019 +0100 Issue 5610/2: add Changes entry commit e6cdaabb97264bc5df89309020b89263a0e5e458 Author: Malte Meyn lilypond@maltemeyn.de Date: Thu Nov 21 12:49:28 2019 +0100 Issue 5610/1: add suggestAccidentals = #'cautionary option Setting suggestAccidentals to 'cautionary now prints only cautionary accidentals (input by ?) as AccidentalSuggestion.
add property label-alignments to OttavaBracket
Yes, this needs some discussion, therefore I set it to needs_work.
How does this look with clefs other than treble? And with other values for break-align-symbols?
add changes entry (untested, see mail on lilypond-devel) http://codereview.appspot.com/577130043
This is fixed in current master and therefore it’s a duplicate of a fixed issue which I’m pretty sure exists but cannot find …
Yes, they do. Consistency of '' and "" with the surrounding code makes sense (maybe it would be nice to be consistent in the whole file/project, but that’s another question and would probably need a large number of changes for little benefit). I didn’t know that they are basically the same.
I’m very late to the review party and don’t know much about python but maybe you (Jonas) could look at my questions on Rietveld before pushing?
I’m very late to the review party and don’t know much about python but maybe you (Jonas) could look at my questions before pushing?
fix stem tremolo on rests crash
commit 2823ff0e87d99bf2a7bd8c662e085067c9426413 Author: Malte Meyn lilypond@maltemeyn.de Date: Sat Oct 19 12:38:37 2019 +0200 Issue 5579: fix stem tremolo on rests crash Putting a stem tremolo on a rest (f. e. r4:32) doesn’t make LilyPond crash anymore.
fix stem tremolo on rests crash
And “=on” can be omitted but there is no short form for disabling a feature. Yes, there is: -liga turns liga off.
Add user-definable ottavation markups
commit 2f1649830bce08ce351ee34aa1d1de8266d9af39 Author: Malte Meyn lilypond@maltemeyn.de Date: Tue Oct 1 17:54:09 2019 +0200 Issue 5559/4: fix regression (ambitus with ottava) commit 6f319a862dc9333ed720e989c881b16cf20710e9 Author: Malte Meyn lilypond@maltemeyn.de Date: Wed Oct 2 10:23:18 2019 +0200 Issue 5556/3: make OttavaBracket text default bold commit 608aa5598868a3772b6ba66f2b3804c9477ffcb3 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Sep 27 10:26:47 2019 +0200 Issue 5559/2: add regtest...
crash: Assertion `!is_empty ()' failed.
crash: Assertion `scores.size () > 0' failed.
This was fixed together with [#5562]: commit 7e6a95662522ef586614bf547539b2b05e4afb23 (HEAD -> malte/crash-slur-5562, origin/staging) Author: Malte Meyn lilypond@maltemeyn.de Date: Mon Sep 30 16:58:59 2019 +0200 Issue 5561/5562: slurs work without NoteHead stencil While searching for slur configurations LilyPond crashed on NoteHeads without stencil because of empty extents. Also, when there cannot be found a viable slur config, this is reported as a warning rather than a failed assertion.
crash: Assertion `!is_empty ()' failed.
commit 7e6a95662522ef586614bf547539b2b05e4afb23 Author: Malte Meyn lilypond@maltemeyn.de Date: Mon Sep 30 16:58:59 2019 +0200 Issue 5561/5562: slurs work without NoteHead stencil While searching for slur configurations LilyPond crashed on NoteHeads without stencil because of empty extents. Also, when there cannot be found a viable slur config, this is reported as a warning rather than a failed assertion. This fixes also [#5561].
make edges of brackets dashable
commit 2c2908c905ba822ef656b06b1cc4f0ca33960c9c Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Sep 29 10:10:35 2019 +0200 Issue 5563: make edges of brackets dashable The new boolean grob property dashed-edge controls whether the edges of a dashed bracket are solid or dashed.
remove script-chart.ly
commit 09bc2e2ed7a0870a21fd05b84c1fd1050419ed03 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Sep 27 12:39:07 2019 +0200 Issue 5560: remove script-chart.ly This file was used only in the German documentation. Replacement was copied from the English version.
This one will be fixed together with [#5562].
crash: Assertion `!is_empty ()' failed.
crash: Assertion `scores.size () > 0' failed.
crash: Assertion `!is_empty ()' failed.
You can even omit the \omit Flag to reproduce that bug (if it is one, see my comment at issue 5561)
Hm … is it really a bug that LilyPond cannot find a nice slur config if it has nothing to attach the slur to? If you need an invisible attachment point, you can use point-stencil: { \omit Stem \override NoteHead.no-ledgers = ##t \override NoteHead.stencil = #point-stencil b( b) }
Change to ottavation lines
Change to ottavation lines
This was fixed in 2.19.14: commit 0119c1b84108674cf2b1c72bd8c231d831ce1f0f Author: Keith OHara k-ohara5a5a@oco.net Date: Sun Aug 24 15:54:45 2014 -0700 Ottava Bracket bounds; issue 3690 Ottava Bracket: do not dash edges; issue 3866 However IMHO it would be useful to have the possibility to dash the edge if the user wants that, see the real world examples at https://notat.io/viewtopic.php?f=2&t=522
Sorry … It seems like me and make doc will never become friends. (Fun fact: I made this patch because make doc failed when I forgot to change script-chart.ly every time a script was added.) I tried to make doc before uploading but it failed due to some misconfiguration. It was definitely not that typo-related error so I thought it’ll be okay without testing … I’ll try to repair my config and make doc first before uploading a corrected patch set.
Mismatched alternative blocks with completion_heads_engraver causes unending loop
And it contradicts issue [#5240]. You cannot have both—single moment brackets and adjacent brackets—with the current input syntax.
You don’t need another staff-size: \version "2.21.0" \paper { indent = 10\cm } << \new Staff << d' \\ <c' a> >> \new Staff <a' b'> >> Alternatively, you can keep the default indent and #(set-global-staff-size 9)
You don’t need another staff-size: \version "2.21.0" \paper { indent = 10\cm } << \new Staff << d' \\ <c' a> >> \new Staff <a' b'> >> Alternatively, you can keep the default indent and #(set-global-staffsize 9).
\ottava doesn’t confuse ambitus
commit 04a0052411d2cd635a7d719e03e62cf84df9ec59 Author: Malte Meyn lilypond@maltemeyn.de Date: Thu Jul 11 10:43:31 2019 +0200 Issue 5532/2: add regtest commit 3300acdd8dbe37063ae7d49167efa0294bb1f59e Author: Malte Meyn lilypond@maltemeyn.de Date: Thu Jul 11 10:40:23 2019 +0200 Issue 5532/1: \ottava doesn’t confuse ambitus
Completion_heads_engraver and dotted breve
commit 49f41bf1c64ae1e2490571e73a85cbc4b2a9fb27 Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Jul 7 18:07:58 2019 +0200 Issue 4362/2: add regtest commit 17d3d3a1515e74f5aaa7f62604994cfdc1391361 Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Jul 7 12:55:19 2019 +0200 Issue 4362/1: head completion uses dotted breves Completion_heads_engraver and Completion_rest_engraver now use dotted breves, longas and maximas in the same way they use shorter dotted durations.
Related: [#5520]
Related: [#4396]
Improvements to \ambitusAfter
commit 2b52bc2bf1d4d4e505792f074442d4cabb031f06 Author: Malte Meyn lilypond@maltemeyn.de Date: Sat May 18 11:05:02 2019 +0200 Issue 5520/2: add \ambitusAfter to Changes commit 03f4723afcdee9ede15feddacad336d9a067ca8e Author: Malte Meyn lilypond@maltemeyn.de Date: Sat May 18 11:04:26 2019 +0200 Issue 5520/1: Improvements to \ambitusAfter • added docstring • added search for parent Score context for more flexible use • added some missing space-alist entries
I think this was fixed in 2.19.0.
Completion_heads_engraver and dotted breve
Completion_heads_engraver and dotted breve
add fermata markup commands
commit c9286e87ee523fcfb9a4501c75490834306bdb2b Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Apr 28 15:01:41 2019 +0200 Issue 5486/2: add fermata commands to NR commit ff348fa75a77cc31832d321316e0a3230e2b0243 Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Apr 28 10:10:06 2019 +0200 Issue 5486/1: add very short/Henze fermata commands
Damn. I’ll probably never learn that, sorry :( I did a make doc but only for the english version. Maybe I should just replace that script-chart.ly thing from the german documentation (the only translation that still uses it) by whatever the english version does.
Now that [#5511] is solved I’m not sure we need markup commands for all fermata types. Do we? If someone wants to write \markup \column { "ad lib." \longfermata } couldn’t they just use \markup \column { "ad lib." \musicglyph #"scripts.longfermata" }? You wouldn’t have automatic directions then. But to me it seems as if adding six new markup commands or a single fermata markup command that can do fermatas but not other scripts much effort for little benefit.
add articulation support to multi measure rests
commit 59284fa692be68868e1a69ff7d27689ec1e61b8e Author: Malte Meyn lilypond@maltemeyn.de Date: Sat Apr 20 17:10:43 2019 +0200 Issue 5511/5: doc: Update translated docs de has a translation of the update, ca/es/fr/it/ja have the offending sections commented out and a TODO comment commit 200658ca20d19cc992baacd9e8694574176cbb92 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Apr 19 14:32:19 2019 +0200 Issue 5511/4: doc: NR and Changes commit 453fa92e43df2e70ed4d2555b3bb09b38bedf73f Author: Malte...
Some more observations: \version "2.21.0" \markup "The staff extends not only one measure but the whole length." << { b4 \new Voice { b64 } b4 } \repeat unfold 16 b4 >> \markup "The order of staves doesn’t matter, and explicitely creating staves doesn’t help." << \new Staff \repeat unfold 16 b4 \new Staff { b4 \new Voice { b64 } b4 } >> \markup "The actual duration doesn’t matter if a long duration is scaled down." << \new Staff { b4 \new Voice { b4*1/16 } b4 } \new Staff \repeat unfold 16 b4 >>...
That bug seems to be introduced somewhere between 2.14.2 and 2.16.2. Using the former, all examples look fine.
No problem :) I just should’ve tested at least one document …
Oops … I didn’t question Werner’s suggestion on the list (now it’s clear that it was pseudocode) and tested only english and german versions. Mea culpa.
add articulation support to multi measure rests
Hm … deprecating \fermataMarkup will break make doc, setting to needs_work. And I haven’t added a Changes entry yet.
needing \fermataMarkup instead of \fermata for MultiMeasureRests is unintuitive, maybe we can make one command that works both for Rests and MultiMeasureRests [#5511] tries to solve that problem.
Issue [#5486] will wait for this.
add fermata markup commands
Setting to needs_work for the following reasons: very short and Henze fermatas need commands too there is discussion on Rietveld about making a single versatile command for all fermata types needing \fermataMarkup instead of \fermata for MultiMeasureRests is unintuitive, maybe we can make one command that works both for Rests and MultiMeasureRests I don’t have time until April or May to do anything of the above
@end lilypond is missing here.
I forgot too but you could have a look at the discussions (issue tracker and mailing list) about issue 5251, where I added a snippet to LSR.
add very short and Henze fermatas
commit 77b98cbbc6093b45e3e9040532e7bce38ffd0db4 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Mar 1 10:33:10 2019 +0100 Issue 5487/2: add new fermatas to Changes doc commit 1284c743b02c16e77cd47aac10c590aee1ba66dc Author: Malte Meyn lilypond@maltemeyn.de Date: Thu Feb 28 21:38:37 2019 +0100 Issue 5487/1: add very short and Henze fermatas These were missing for SMuFL compliance. This contains the addition of the fermatas to encodingdefs.ps.
fix for wrong clefs.varC_change
improve prall glyphs
commit 56942ccc5f5a7ac0088b16e3f7d28ff6bffc530d Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Mar 3 09:57:10 2019 +0100 Issue 5489/2: rename trilelement → trillelement including convert-ly rule commit 2afb45bd85d85ddd06855aa3eea730d72581444c Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Mar 3 09:47:56 2019 +0100 Issue 5489/1: improve prall glyphs • fix erroneous shape of pralldown/prallup • enlarge arc of downprall/pralldown • move and shorten line of lineprall
Issue 5490: fix for wrong clefs.varC_change
commit 3ba581df6aa154ec401e1486586f604b86277cf0 Author: Malte Meyn lilypond@maltemeyn.de Date: Sun Mar 3 11:09:54 2019 +0100 Issue 5490: fix for wrong clefs.varC_change For solving Issue 5278 I changed the bounding box of the varC clefs whithout noticing that the height of the vertical bars relies on the box height. This commit fixes that.
undefined operation (GCC warning) in page-turn-page-breaking.cc
commit 5eb392ddd5f78dd7a071d48b1f6ab6e859b6dc8d Author: Malte Meyn lilypond@maltemeyn.de Date: Thu Feb 28 13:48:11 2019 +0100 Issue 5485: avoid -Wsequence-point warning
(although I don't know why I am not seeing any extra diffs - do we not reg test these glyphs anywhere?) No, we don’t, only \prall is used in some regtests. Would the normal regtests show differences? I thought they only show differences in positioning, not in appearance of grobs/glyphs.
Issue 5490: fix for wrong clefs.varC_change
I’m sorry. I thought I had to add the new glyphs to script-chart.ly. But it seems like something is missing there, maybe script commands like \veryshortfermata. Maybe we should update this part of the german translation so that the file script-chart.ly isn’t needed anymore. I’ll upload a next patchset that simply doesn’t add the new fermatas to script-chart.ly.
add fermata markup commands
Waiting for [#5487], probably needs some more discussion.
undefined operation (GCC warning) in page-turn-page-breaking.cc
undefined operation (GCC warning) in page-turn-page-breaking.cc
make doubleRepeatType fallback & default the same
commit 5eb848b59b72cef0150e2c9f49a083e5a32f7fa3 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Feb 22 17:54:57 2019 +0100 Issue 5484: set doubleRepeatType fallback to default The hardcoded fallback was ":|.|:" so \unsetting doubleRepeatType changed the output.
Ukulele fretboard for cis:m7 and des:m7 are wrong
Solved: [#5458]
Ukulele fretboards for dim7 chord have wrong chord names
Solved: [#5458]
Why did you delete such a large number of diagram definitions there? Edit: Oh, I see. You didn’t. Issue [#5458] added diagrams that aren’t present in your suggestion.
Why did you delete such a large number of diagram definitions there?
ly: updates to hel-arabic.ly
document restNumberThreshold
commit c7bf27ada348587be6028a0fc48d367b4dbffec9 Author: Malte Meyn lilypond@maltemeyn.de Date: Fri Dec 28 11:55:37 2018 +0100 Issue 5251/3: add regtest commit 349fb5690375b28e6fe3df3013997f7bd8394b51 Author: Malte Meyn lilypond@maltemeyn.de Date: Wed Dec 26 13:31:28 2018 +0100 Issue 5251/2: add snippet to NR commit 253b2489859c49c6b116acf9e18cc380351a3719 Author: Malte Meyn lilypond@maltemeyn.de Date: Mon Dec 24 13:08:57 2018 +0100 Issue 5251/1: set default restNumberThreshold = 1 Also restNumberThreshold...
Footnote separator line