Activity for Sv Lockal

  • Sv Lockal Sv Lockal posted a comment on discussion General Discussion

    The issue occurs in miopen, where std::isfinite is applied in templated code for double/float/half_float and half8 (miopen defines namespace std { bool isfinite(half8 x){...} } for their half8 type). Regarding the issue with libc++, a quick discussion occurred in https://github.com/llvm/llvm-project/pull/98841, the issue was fixed and now std::isfinite(half_float_variable) will work, but it will implicitly cast to float (or to double, or to long double, or fail with ambiguous call) in the same way...

  • Sv Lockal Sv Lockal posted a comment on discussion General Discussion

    Hi, I noticed a few problems affecting ROCm/half and upstream (v2.2 incl. trunk), so I'll report in both places. Both are related to std::isfinite. First problem is that it does not work with libc++. Here is a breakdown why: 1) Since C++11 std::isfinite is defined for integral types (having specific traits) 2) Used trait is std::is_arithmetic, it uses std::is_floating_point. Both traits have no specialization for half_float::half 3) What happens in gcc/libstdc++/msvc is that std::isfinite(half_value)...

1
MongoDB Logo MongoDB