Activity for Philip Leishman
-
Philip Leishman posted a comment on ticket #1692
I have been away from my computer for quite a while - I missed all the excitement. Thanks to Ted for sorting all this out !
-
Looking at the first few comments here - I noticed the one about "direct export / render". That makes sense if I just have synth plugins and audio tracks. I have made a try at this - see my feature-462-lv2 branch. There is a new command in the File->Export menu. This will record the next play to a wav file. It would be nice to render in non real time but that is more difficult. No idea how to approach that. Attached is an example - part of the aveverum example rendered with the calf fluidsynth and...
-
fix logic bug in composition export
-
add rendering of audio + synth plugin
-
OK
-
Thanks to Ted for finding this. Btw. I ran the Shortcut Editor Test Plan and it worked OK.
-
The shortcut editor was maintaining the shortcuts in a set so the order from the .rc files was lost. I have moved to using a list to maintain the order. That just means some manual checking for duplicate shortcuts. The menus now show the correct shortcut Please merge
-
bug 1702 fix shortcut oder
-
add clear button to shortcut editor filter
-
Merge branch 'master' into bug-shortcut-order
-
update shortcut editor to maintain shortcut order
-
Shortcut order not respected
-
Thanks for finding that. The fix was quite easy. See branch
-
fix program list on delete bank
-
OK - this was more difficult than I thought. The original concept was to make changes in the gui widgets and use these to update the devices. I have changed to making direct changes to the device and using a studio/device observer mechanism to update the widgets. That means undo redo works automatically. Also removed a lot of unnecessary state from the editor classes - the state is in the device. So all together a lot of changes - still may be some bugs around ! I believe I have addressed the original...
-
add librarian editor to bank editor
-
Merge branch 'master' into bug-1692-device-manager
-
fix paste selection problem
-
clean up bank editor
-
update BankEditorDialog
-
fix crash file new
-
Yes definitely reproducible - but is it a bug ? When the segment is copied with Ctrl+Drag the original segment is moved to the new location and the copy is inserted at the original position. You can confirm this by inputting some notes in the open matrix editor after the Ctrl+Drag - the notes are inserted in the segment at the "drop" position. So when this segment is split the original segment is destroyed and the Matrix editor MUST close!
-
Merge branch 'master' into bug-1692-device-manager
-
fix crash on studio delete
-
Merge branch 'master' into bug-1692-device-manager
-
Turn repeats into copies misses last segment
-
I beleive this is < / <= issue going to <= seems to fix it Please merge
-
bug 1696 repeats to copies
-
Fix range of segements for repeats to copies
-
bug 1698 repeat segments illegible
-
avoid greying out repeats
-
fix device rename on import
-
BankEditorDialog updates
-
cleanup BankEditorDialog
-
clean up bank editor
-
update MidiKeyMappingEditor
-
update for bank editor
-
On my system the scroll bar is present ! The QComboBox should have the ScrollBarAsNeeded policy by default. I tried on my virtual machine (fedora 40) and indeed the scroll bar is missing. Another gnome/kde thing ? In the code the scrollbar policy is set explicitly for the program combobx. I have set it for the banks combobx. That seems to work. Please merge
-
bug 1695 missing scrollbar in banks combobox
-
set scrollBarPolicy for bank combobox
-
update MidiPrgramsEditor
-
use midi min and max values
-
Merge branch 'master' into bug-1692-device-manager
-
further work on bank editor
-
further improvements in bank editor
-
bank editor updates
-
fix update in DeviceManagerDialog
-
fix compile error
-
Merge branch 'master' into bug-1692-device-manager
-
further improvement in bank editor
-
initial update for BankEditor
-
Merge branch 'master' into bug-1692-device-manager
-
Merge branch 'master' into bug-1692-device-manager
-
Merge branch 'master' into bug-1692-device-manager
-
Hmm.. OK - but I think I still prefer just highlighting the current track. I guess it is a matter of taste ! So....... I have implemented a setting for how to do the highlighting - it can be chosen in the View menu of the notation editor. I made the default your suggestion above - but that can be changed. Please merge,
-
notation with different highlight modes
-
That is quite right. The BankEditor still needs a lot of work. This merge request is not ready for merging. What should work better now is the DeviceManager - undo redo should work OK. Don't look at the bank editor yet !!
-
add observers to BankEditor
-
The behaviour you see is a result of the fix for bugs 927 and 1679. So it is intentional that after undo the cursor is reset to where it was before the action was initiated. Not sure how difficult it would be to stop this behaviour if the cursor is manually changed. Is this what we want ? Any ideas or suggestions ?
-
I agree. In my latest version stop just does stop with no jump to the current staff. This feels right for me - If I want to get back to the current staff a left or right arrow will do that.
-
Playback pointer and autoscroll with multiple segments per track
-
Bank Editor: Allow bank sharing for percussion
-
bug 1692 Device manager and Bank editor
-
I have made a start here. At this stage I have just improved the undo/redo behaviour in the DeviceManagerDialog Next step - the bank editor See merge request Comments welcome
-
improve undo/redo in DeviceManageDialog
-
update device manager to show undo properly
-
I never used this dialog much - I was always happy with good old GM. But things are certainly broken here. At first I thought undo redo was not working properly - open the device manager - click on "New" and then press control-Z. The new device is still there - but not really - close and reopen the dialog and it is gone. So an update of the dialog is missing! And yes that undo for every character typed is not good. Another problem: Create a new device and add 2 banks. Set the MSB for the first bank...
-
I have renamed some things and now deal with (hopefully) all graphical elements in the staff. For bug 1 and 2 above I prefer solution 2 - much easier to implement. Does anyone need the limiting of the cursor to the current staff ? Getting back to the current staff is easy with left or right arrow. I have removed the limiting of the cursor so - no more jumps !
-
bug 1672 rename editing->current. Change opacity for all graphics items. Cursor not jumping to current staff
-
extend editing highlighting to additional elements
-
bug 1672 notation editor multiple staffs
-
OK - tricky one - I will have a go. First Bug 3 above - The select all option seems doubtful - very expensive (for performance testing the Brandenburg-No3 example is good) I had a try at changing the opacity of the elements - that seems to work and is much more efficient! Please have a look and merge if this seems a good idea
-
setEditing call in NotationElement addItem
-
change staff highlighting for current staff
-
Merge branch 'master' into feature-462-lv2
-
handle bad plugin better
-
Not directly related to lv2 but I got some compile errors on the latest git. Please merge
-
fix compile errors
-
I have added a check for the existence of the gui library (See the mails from Chuck Elliot on the user list). Please merge
-
add lv2 check for gui library ok
-
To summarize: install the qt5-style-plugins package set the environment variables: export QT_QPA_PLATFORMTHEME=gtk2 export XDG_SESSION_TYPE=x11 and rosegarden should work with the lv2 plugins and gtk editors
-
So one problem was my audio setup - using pipewire. After sorting that out I still had some problems with the editor windows - probably related to wayland. I found a workaround: export XDG_SESSION_TYPE=x11
-
I installed fedora 40 in a virtual machine and I could reproduce the problem. I think this is the usual qt/gtk2/gtk3 clash. If I run with the setup described in bug 1674 rosegarden starts ! The fix was: install the qt5-style-plugins package export QT_QPA_PLATFORMTHEME=gtk2 So now rosegarden is running (compiled with lilv and gtk2) but I cannot get an lv2 editor window to open. Neither the gtk editors nor the X11 editors start (maybe a wayland problem ?) I am still looking into this
-
Rosegarden uses gtk2 so the gtk2 libs must be installed. Maybe that is the problem !
-
Any details about the gtk2 problems ?
-
Yes - I uninstalled gtk2-devel and got a link error. Fixed in branch feature-462-lv2
-
fix link problem with no gtk2
-
Merge branch 'master' into feature-254-midi-action
-
Fix bug with timidity -Oj -iA
-
fix timidity -Oj -iA
-
I did not have the hardware to test this directly. I wrote a small test program which creates 2 duplex ports. See attached - it may be helpful compile with: g++ apt.cpp -o apt -lasound
-
update MidiToActionDiaplog
-
Merge branch 'master' into feature-254-midi-action
-
Just bumping this one again I merged the newest master and made a few minor improvements
-
MIDI Actions
-
Well I didn't even know about these track settings ! There is always something new to learn about in Rosegarden. It seems the Midi behaviour can be finely tuned on a track by track basis. Thanks for the Info Ted !
-
This behaviour certainly seems to be intentional. There is a comment in RosegradenSequncer.cpp : // Send the incoming events back out using the instrument and // track for the selected track. Note that this behaviour can be configured using the Modifiy MIDI Filters dialog in the Studio menu. Here the note on/off events can be filtered out (THRU events to ignore). Does this give you what you need ?
-
Yes - the dialog is not really usable as it is. I have included expanding the columns to fit contents and saving the window geometry. Please merge
-
feature 520 unused audio window geometry
1 >