Activity for Luke Cann
-
Luke Cann modified a comment on merge request #47
Hi Jeff, I was eventually able to write a test for 427. I've rebased on master and squashed my changes down to three commits, one for each issue. This includes the changes to changes.xml that you requested. I looked through the dev guide. It seems to contain everything you've walked me through here at-least. It may be usefull to have some notes on code style. Most things, such as brackets and indentation is pretty clear at first glance but other things may not be.
-
Hi Jeff, I was eventually able to write a test for 427. I've rebased on master and squashed my changes down to three commits, one for each issue. This includes the changes to changes.xml that you requested. I looked through the dev guide. It seems to contain everything you've walked me through here at-least. It may be usefull to have some notes on code style. Most things, such as brackets and indentation is pretty clear at first glance but other things may not be.
-
Hi Jef, I was eventually able to write a test for 427. I've rebased on master and squashed my changes down to three commits, one for each issue. This includes the changes to changes.xml that you requested. I looked through the dev guide. It seems to contain everything you've walked me through here at-least. It may be usefull to have some notes on code style. Most things, such as brackets and indentation is pretty clear at first glance but other things may not be.
-
B427: Fix normalization of schemas in DatabaseDataSet
-
B426: Inherit case sensitivity in FilteredDataSet
-
B428: Fix value casting in IsActualWithinToleranceOfExpectedTimestampValueComparer
-
Fixed normalisation of schemas in regard to case sensitivity in DatabaseDataSet SchemaSet
-
B426: Inherit case sensitivity of wrapped set in FilteredDataSet
-
B428: Cast values to expected type in IsActualWithinToleranceOfExpectedTimestampValueComparer
-
B427: Add case sensitivity test for DatabaseDataSet
-
B427: Add case sensitivity test for DatabaseDataSet
-
B426: Inherit case sensitivity of wrapped set in FilteredDataSet
-
Fixed normalisation of schemas in regard to case sensitivity in DatabaseDataSet SchemaSet
-
B428: Cast values to expected type in IsActualWithinToleranceOfExpectedTimestampValueComparer
-
Unfortunatly i am using Assertion.assertWithValueComparer directly instead of DefaultPrepAndExpectedTestCase so that commit doesn't fix the issue for me. I've added tests to 426 & 428 but i'm having a hard time with 427. I wanted to add the test to DatabaseDataSet_MultiSchemaTest but the issue doesn't seem to be reproducable with the H2 DB. I'll try again later with the mssql ITs as that is where i initially found the issue.
-
B428: Add test to verify converting of string values in IsActualWithinToleranceOfExpectedTimestampValueComparer
-
B428: Refactor casting of values in IsActualWithinToleranceOfExpectedTimestampValueComparer
-
IsActualWithinToleranceOfExpectedTimestampValueComparer now casts to the expected type using the dataType provided to the comparer instead of assuming the values will be Timestamps.
-
B426: FilteredDataSet does not inherit case sensitivity of wrapped set
-
Fixed FilteredDataSet not inheriting the case sensitivity of the data set it wrapped
-
Fixed normalisation of schemas in regard to case sensitivity in DatabaseDataSet SchemaSet
-
Hi Jeff, I've raised bugs for all three of the fixes: 426: FilteredDataSet does not inherit case sensitivity of wrapped set 427: DatabaseDataSet SchemaSet is incorrectly normalizing schema names in regard to case sensitivity 428: IsActualWithinToleranceOfExpectedTimestampValueComparer assumes values are represented as Timestamps I'll implement tests for each one and commit with the relevant bug reference. I've done 426 and i'll get to the others soon. This issue came about when i was trying to use...
-
IsActualWithinToleranceOfExpectedTimestampValueComparer assumes values are represented as Timestamps
-
DatabaseDataSet SchemaSet is incorrectly normalizing schema names in regard to case sensitivity
-
B426: FilteredDataSet does not inherit case sensitivity of wrapped set
-
FilteredDataSet does not inherit case sensitivity of wrapped set
-
IsActualWithinToleranceOfExpectedTimestampValueComparer now casts to the expected type using the dataType provided to the comparer instead of assuming the values will be Timestamps.
-
Case sensitivity fixes in filtered data sets and database data set schema sets
-
Fixed normalisation of schemas in regard to case sensitivity in DatabaseDataSet SchemaSet
-
Fixed FilteredDataSet not inheriting the case sensitivity of the data set it wrapped
1
