knight-of-ni

Hi Daniel, Yes, I have been using that patch with Netatalk since Fedora 33. If I recall that is when tracker 3 was introduced to Fedora. I am fairly sure netatalk would not build without that patch. Thanks, Andy No Trees were killed in the sending of this message. However, a large number of electrons were terribly inconvenienced. From: patches@netatalk.p.re.sourceforge.net patches@netatalk.p.re.sourceforge.net on behalf of Daniel Markstedt himasaram@users.sourceforge.net Sent: Saturday, February...

Ah, right. That's the patch I re-worked and have been using for netatalk in fedora branches. Seems I forgot to submit it upstream. Thanks for catching that. Thanks, Andy No Trees were killed in the sending of this message. However, a large number of electrons were terribly inconvenienced. From: patches@netatalk.p.re.sourceforge.net patches@netatalk.p.re.sourceforge.net on behalf of Daniel Markstedt himasaram@users.sourceforge.net Sent: Saturday, February 11, 2023 3:45 PM To: [netatalk:patches] 147@patches.netatalk.p.re.sourceforge.net...

The problem on fedora rawhide was unrelated and has been resolved. A new netatalk package has been built for fedora rawhide repos: https://koji.fedoraproject.org/koji/taskinfo?taskID=63712482 Thanks for your initial patch and followup.

I reworked the patch again. This time I didn't use AX_COMPARE_VERSION and after further testing here is what works for me: https://github.com/knight-of-ni/Netatalk/commit/a7ff155b4a907af0cb979863758137aa5f8dce3f This patch was tested on Fedora 33 and then on CentOS 7 to verify backwards compatibility. I'm running into a different problem on fedora rawhide, but it might not have anything to do with this patch...

OK, almost have it. With a few more changes, I got the patch to build. This line in the patch fails: AC_DEFINE(HAVE_TRACKER3, [test x"$ac_cv_tracker_pkg_version" = x"3.0"], [Define if Tracker3 is used]) Autotools takes that test and stuffs it into config.h verbatim: #define HAVE_TRACKER3 test x"$ac_cv_tracker_pkg_version" = x"3.0" Gcc doesn't know how to handle this and throws an error. The following change allows the build to complete: AX_COMPARE_VERSION([$ac_cv_tracker_pkg_version], [ge], [3.0],...

Thanks for the assist. Note I also needed to patch configure.ac to look for tracker3 binary. Your call if you want to add it to your patch or leave separate. https://github.com/knight-of-ni/Netatalk/commit/dca1ebd6a8af9f258e8aaf6931af9ba870b9e252

I am attempting to use this patch for netatalk package in fedora repos, but the build fails: make[4]: Leaving directory '/builddir/build/BUILD/netatalk-3.1.12/etc/spotlight' In file included from sparql_parser.y:14: ../../include/atalk/spotlight.h:32:10: fatal error: libtracker-miner/tracker-miner.h: No such file or directory 32 | #include <libtracker-miner/tracker-miner.h> tracker-miner.h is not part of tracker3-devel package. I am not familiar with the tracker API so any help to fix this would...

It sounds like you are using an old srpm package. The 5:3.1.12-10 Netatalk package in Fedora builds just fine on RHEL 8. Redhat decided to withold several devel packages in RHEL 8, two of which are needed to build netatalk. Once I navigate through this, netatalk will be built and live in EPEL 8. In the meantime, feel free to use my copr repo: https://copr.fedorainfracloud.org/coprs/kni/netatalk-el8/