Khushil Mistry posted a comment on ticket #749

Hey, I have done required changes and checked on Thunderbird. Please review it.

Khushil Mistry modified a comment on ticket #749

Hey, I have few questions regarding coding standards. I have attached SS of my changes. 1 .What is Autocrypt is hardcoded here. Should I add it in enigmail.dtd in locale/en-US. Is there any need to add this Entity else where ? 2. Styling for Autocrypt is inlined. Where should I add it ? 3. I have removed decription. Should I remove it from enigmail.dtd also or keep it there for any future reference/use ? 4. Also, there is an issue : I have added <html:a> tag here. I want to redirect user to default...

Khushil Mistry posted a comment on ticket #749

Hey, I have few questions. I have attached SS of my changes. 1 .What is Autocrypt is hardcoded here. Should I add it in enigmail.dtd in locale/en-US. Is there any need to add this Entity else where ? 2. Styling for Autocrypt is inlined. Where should I add it ? 3. I have removed decription. Should I remove it from enigmail.dtd also or keep it there for any future reference/use ?

Khushil Mistry modified a comment on ticket #749

I have gone through the source code for Transfer Settings as well as How Autocrypt Setup Message is and it is communicating to other devices. Now, I have fair idea about Autocrypt and little idea about how Autocrypt Message Setup is created. I am still digging in to figure out the whole Setup. For this bug, should I remove all the descriptions and change the name of the Lable according to above recommendations and also add link to https://autocrypt.org/ ?

Khushil Mistry modified a comment on ticket #749

I have gone through the source code for Transfer Settings as well as How Autocrypt Setup Message is and it is communicating to other devices. Now, I have fair idea about Autocrypt and little idea about how Autocrypt Message Setup is created. For this bug, should I remove all the descriptions and change the name of the Lable according to above recommendations and also add link to https://autocrypt.org/ ?

Khushil Mistry posted a comment on ticket #749

I have gone through the source code for Transfer Settings as well as How Autocrypt Setup Message is and it is communicating to other devices. Now, I have fair idea about Autocrypt and little idea aabout how Autocrypt Message Setup is created. For this bug, should I remove all the descriptions and change the name of the Lable according to above recommendations and also add link to https://autocrypt.org/ ?

Khushil Mistry posted a comment on ticket #749

Hey, I want to work on this Enhancement. Can you guide me little bit ?

Khushil Mistry posted a comment on ticket #743

I have done required changes and also checked the functionalities after building and integrating add on on thunderbird.

Khushil Mistry posted a comment on ticket #743

Okay. Will Add Radio button for the same enigmailEditIdentity.js|xul. Will make a combine Patch by end of the day.

Khushil Mistry posted a comment on ticket #743

Thanks for review. What should I exactly do for functional nitpick ? Just remove the mail.identity.default.attachPgpKey from all the default option ? Also, Should I make a patch for this new changes or have to combine them with above patch ?

Khushil Mistry modified a comment on ticket #743

Removed OpenPGP Header from Enigmail

Khushil Mistry posted a comment on ticket #743

Removed OpenPGP Header from Enigmail

Khushil Mistry modified a comment on ticket #762

Khushil Mistry modified ticket #762

Removed OpenPGP Header from Enigmail

Khushil Mistry created ticket #762

Removed OpenPGP Header from Enigmail

Khushil Mistry posted a comment on ticket #743

Thanks for the description. I will work upon this.

Khushil Mistry posted a comment on ticket #743

Hey, I want to work on this bug. Can you guide me what should be done ? Which header is it referring to ?