junkyardsparkle

Not from me, unless it's worth keeping open a little longer as a reminder to actually add the crop tags to the profiles that need them... otherwise, I could add FIXME comments to the profiles, for the ones I can remember having this "feature"...

That's interesting, I've seen several cases similar to this one where maximal_radius would be useful. I did try the <crop> element, but it didn't seem to have any effect in darktable, at least. Implementing it as you describe sounds good to me, but I guess should be discussed somewhere. It might be best if there was still a way to get the current "all-the-pixels" behavior if it's desired.

The problem isn't that the in-camera cropping affects the lensfun corrections, it's that Lensfun/darktable doesn't do the additional cropping that the camera does in order to hide the edges of the image circle in the corners. You can see this best on the second linked image (YIMG_0026.CR2)... with default correction in darktable there are still visible traces of the physical edge of the image circle, most easily noticed in the lower left. You can, of course, adjust this for each image in darktable...

The problem isn't that the in-camera cropping affects the lensfun corrections, it's that Lensfun/darktable doesn't do the additional cropping that the camera does in order to hide the edges of the image circle in the corners. You can see this best on the second linked image (YIMG_0026.CR2)... with default correction in darktable there are still visible traces of the physical edge of the image circle, most easily noticed in the lower left. You can, of course, adjust this for each image in darktable...

The problem isn't that the in-camera cropping affects the lensfun corrections, it's that Lensfun/darktable doesn't do the additional cropping that the camera does in order to hide the edges of the image circle in the corners. You can see this best on the second linked image (YIMG_0026.CR2)... with default correction in darktable there are still visible traces of the physical edge of the image circle, most easily notices in the lower left. You can, of course, adjust this for each image in darktable...

You can just place the XML file in <home_directory>/.local/share/lensfun and LensFun should find it. If you've never used the lensfun_update_data utility before, this directory may not exist; in that case, just create it.

You can just place the XML file in <home_directory>/.local/share/lensfun and LensFun should find it. If you've never used the lensfun_update_data utility before, this directory may not exist; in that case, just create it.</home_directory>

It was recently added to the database, but may not be in update packages yet. The profile is attached if you want to install it manually in the meantime.