John Ehresman

Increase interior width of MarkerSymbol::Plus and Minus to match stroke width

Augment APIs that represent graphical sizes and points with the 'pixels' type

Could you use SCI_SETSELECTIONNCARET & SCI_SETSELECTIONNANCHOR when you want to control which pos is the caret and which is the anchor? In scintilla, the start of selection is merely the min of the anchor & the caret and the end of the selection is the max. Note that this differs from other editor implementations (each does things a bit differently when you get into the details)

Just wanted to say that the qt scintilla code (ScintillaEdit et al) is in use and works well for our purposes. There are a number of different naming conventions (and other conventions) -- some of which comes from the difference between Qt conventions v Scintilla conventions v Python conventions. If changes are to be made, I think they should be in response to specific problems.

Add mayCoalesce arg to BeginUndoAction

Using GetPainter()->setClipRect(QRectFFromPRect(rc), Qt::IntersectClip); in SurfaceImpl::SetClip(PRectangle rc) seems to fix this bug. I haven't seen any regressions after changing it -- though if other platforms intersect the clip, it should be fine. Will run with it and let you know if there are any problems.

Indicator drawn over margin

I'm reasonably sure that setting all of the selection backgrounds elements to have an alpha of 0 would work for multi-phase drawing, but what about single phase? I just switched to using multi-phase to get alpha values to work -- the colors are always opaque in single-phase. Or, does format range always use multi-phase?