Activity for Jonathan Daley
-
Jonathan Daley committed [r321] on Code
intval() works to cast to an int, where old PHP could use the '0 + var' trick
-
need to define getHttpVar before using it
-
-
I've just started getting errors from rcfax.com. My DKIM records are correct, as verified by gmail.com, which shows the proper authentication in their headers. It seems that rcfax is not following the DKIM standard and is imposing a further restriction on the email. I can't get anyone at Ring Central who knows what DKIM records are.
-
Ah, I finally found it. I knew about /etc/usermin/miniserv.conf but I forgot about /etc/usermin/config tempdir was set to /tmp, which has been set that way for a decade. I can't see the code that changed that made that work before, but I've changed it to /tmp/.usermin and now it is happy. It would probably be good to put in a check to never "rm -rf /tmp" just to protect users from themselves. Or maybe automatically put in a suffix of .webmin or .usermin if someone uses /tmp, though maybe the solution...
-
tmp directory is being erased?
-
Tagging 3.3.3 release
-
I like the tagging model that subversion has for easier merging and comparing between versions
-
setting release 3.3.3. I haven't seen any errors in a while, and tested a bunch of stuff
-
bug, probably in converting to php7. I didn't have this plugin installed previously
-
contact.class.php may cause Undefined offset error
-
This was fixed at least by revision 712, if not before.
-
my first attempt at replacing create_function() for the array_filter() call didn't work. Adding a closure does. This is related to bug# 119. It might have been fixed before, but it definitely fixed now
-
rev 635 tried to fix an undefined error, but did it incorrectly. The isset() check needs to be used after the value is defined. This makes refids work for communications/information again
-
whoops, typo - left it in quirks mode which caused all sorts of problems
-
simplified query - it must have been used to do something else in the past
-
I think the unexpected behavior comes from that the "user" who modified it is tied to a "contact" and then we call Contact->sendEmail() which grabs the first email address out of the contact, rather than from the users table. Probably we should use the contact information from the users table, because it didn't work how I expected it either, and sent my wife an email, because she is the first address in the contact card.
-
I've updated this issue here: https://sourceforge.net/p/tab-2/bugs/127/
-
PHPMailer now has a new way to instantiate
-
Logout followed by Login: incorrect redirect (embedded)
-
bug when we change phone to mail on an existing contact
-
Warnings after install
-
updated links to https and new sourceforge formatting. Our hosted example page isn't working - looks like the database is dead. we should check that out at some point
-
our database has limits, so might as well limit the HTML text boxes too, so the user can't easily send in values that are too long, resulting in mysql query errors
-
check for null before trying to diff
-
this only occurs when the contactchangelogger plugin is installed. I think it is fixed in rev 704.
-
check for values before using them fixes #133
-
while checking this, I noted some missing static classes that are required for PHP7. Fixed in rev 703.
-
more php7 changes: need statics
-
Export to vcf causes warnings
-
fixed in rev 666
-
PageContact crashes if user who modified is deleted.
-
I think this is fixed now. I don't see the error.
-
fixed undefined error when deleting contacts
-
Install script crashes Apache server
-
Failed to do query: Table 'databasename.tab3_plugins' do
-
warning about mb_encode_numericentity expecting 3 parameters
-
thanks.
-
MySql error: Incorrect integer value
-
Sync Client Address book options
-
Digging this one up from the ancient past. Did you make any progress on this? I have been trying to figure out a method to make my email client (alpine/IMAP) talk to my phone (Android/Google) and haven't come up with anything yet - the solutions seem fairly complicated. I have gotten my wife's and my email clients to be able to share an IMAP addressbook, which is very handy.
-
Php 7?
-
Address should not display default Country
-
I didn't see your code before fixing it myself. applied in rev. 700.
-
Php 7?
-
I forgot to come back and comment here. The project has supported PHP7 successfully for a while now. There is still some cleanup to do, but my wife is happy that she can now finish her Christmas list on my new database server: 10.3.27-MariaDB-0+deb10u1-log.
-
Relationship plugin: mutual relationship
-
applied in rev 670
-
applied in rev 671.
-
Contact stylesheet fix: "webs, news, media" overflow
-
applied in rev 672
-
Relationship plugin update - show links on contactPage
-
Relationship plugin - crash when deleting a contact
-
applied in rev 673
-
applied in rev 669
-
Relationship plugin PHP Warning
-
I just came across this myself (I recently moved my personal copy of address book to a new server, so hadn't seen this bug before. I fixed it in a different way, by copying code from another section of the software which actually does the right thing and includes the refid when it is needed and uses the auto-increment value from the database when it isn't. We probably need to check other places in the code that use auto-increment values that depended on the old mysql behavior. This particular issue...
-
fix for address trying to set the auto-increment value to '' (apparently NULL is acceptable? Maybe not for auto-increment values, need to check). Closes bug #136
-
undefined variables
-
php7 update
-
php7 upgrades for mysqli_XXX
-
I have a related problem (I think), so I'll add some screenshots to this one rather than open a new bug report. My dialogs (Settings->General, Print, and Presentation) are really big (width is correct, but height is 1.5 times the height of my screen, so I can't reach the ok/cancel buttons unless I use a Alt-mouse drag on the window to move it upwards (I can't move the dialog with the title bar because I need the title bar to go above the edge of my window. I don't know if it is related, but sounds...
-
I have a related problem (I think), so I'll add some screenshots to this one rather than open a new bug report. My dialogs are really big (width is correct, but height is 1.5 times the height of my screen, so I can't reach the ok/cancel buttons unless I use a Alt-mouse drag on the window to move it upwards (I can't move the dialog with the title bar because I need the title bar to go above the edge of my window. I don't know if it is related, but sounds similar. 3.4.8 linux.
-
sounds like preview mode, and since it was posted anonymously, you'll probably never get a response and could close this one.
-
Bug still present in 3.4.8 on my new laptop with a different screen resolution. I see that imgur has erased my initial report, so I've attached a screenshot.
-
Crash on close (with X or Alt-F4)
-
use utf-8 everywhere. (I manually converted my database character set - need to check the database creation code, it probably uses the server default)
-
regression in -r308, we started looking for either beginning or end, when we really want both
-
enable -v for debugging
-
trying to debug parenthesis bug added in last version
-
nobody wants to see their own country do they?
-
hide some stuff during printing
-
when deleting a user, set fields so as to not cause database/key problems. set unknown values to zero so it can be checked for elsewhere
-
subversion cleanup
-
we don't need POP, so get rid of it
-
new version of phpmailer
-
php7
-
fixes for a newer version of mysql (I use MariaDB 10.3.27). It is probably 'strict' mode, which makes NULL need to be explicitly named, and not ''.
-
php7 changes
-
Is that enough fun? Those are the changes I've made over the years - I haven't made many changes in a long time. I'm working on the PHP7 changes now. It is mostly working, though there are so many...
-
don't print empty address labels. remove middle names if they are too long on labels. I just realized that the middle-name might be one thing I added in my own code, so these last changes might not make sense.
-
put a space after the middle name
-
make labels look nicer
-
my wife's changes to the address formatting for labels. Now show full country names for PDF labels. changing order of last/first names. this is probably the first change that maybe other people don't want. But since there haven't been any other changes in a decade maybe no one else cares... :)
-
adding a phone list. adding email export
-
added 'type' parameter for different kinds of lists
-
removed redundant box, since onload was being run twice.
-
remove HTML, and add a header
-
actually added the notes this time. cleaned the line-length code
-
auto-add carriage returns if the line is too long. starting to add notes
-
country should be in uppercase
-
whitespace only
-
fixing up PDF output. removed first page. treat middle name specially, if it starts with a parenthesis. removed URL from footer. don't display group if we are filtering by group. display a shortened name on the sidebar
-
we already have a contact object, don't need to pass in the id
-
need to URLencode the URL
-
PHP notice
-
whitespace only
-
whitespace only
-
delete any relationships that exist in another contact 'towards' this to-be-deleted contact
-
list relationships on contact page, and make link to the related-to contact
1 >