What do you think? Any ideas, comments, suggestions? It sounds reasonable, The main drawback from my perspective is that I have no way of testing if whatever I implement (if you're asking me to implement it) is correct or not. I mean, I just used this ImageCms module to do something that seems sensible and that looks on my screen similar to what e.g. Gimp shows, but I don't know if it's taking into account my monitor profile (if any), or if it's clipping stuff that needn't be clipped, or something...
I've figured out how to read an embedded profile from a pixbuf For the record (in case this becomes useful in the future), this is how I could read the profile: pixbuf = GdkPixbuf.Pixbuf.new_from_file(path) icc = pixbuf.get_options().get('icc-profile', None) if icc is not None: icc = ImageCms.ImageCmsProfile(BytesIO(base64.b64decode(icc))) and to preserve the profile when coverting a PIL image to a pixbuf: icc = image.info.get('icc_profile', None) if icc: pixbuf.set_option('icc-profile', base64.b64encode(icc))...
It's not merged in the (remote) master yet, is it? If isn't, it's probably safe to press the merge button, if that's what you want (although you may get conflicts with your local master branch, if you've merged it there). I don't know how exactly SF works, though, I have mostly experience with GitLab.
Revert "Try to fix random failure to restore window geometry"
Try to fix random failure to restore window geometry
Try to fix random failure to restore window geometry
I've figured out how to read an embedded profile from a pixbuf, so I'll try to rewrite this. Great, looking forward to it! I'm afraid it won't work. Yes, I can read a profile from a pixbuf created directly from file, and yes, I can also make sure that the profile is preserved when converting a PIL image to a pixbuf. But GdkPixbuf does not support CMYK, it only supports RGB (https://docs.gtk.org/gdk-pixbuf/property.Pixbuf.colorspace.html), and a JPG (or anything else, I assume) is probably converted...
I've figured out how to read an embedded profile from a pixbuf, so I'll try to rewrite this. Great, looking forward to it! I'm afraid it won't work. Yes, I can read a profile from a pixbuf created directly from file, and yes, I can also make sure that the profile is preserved when converting a PIL image to a pixbuf. But GdkPixbuf does not support CMYK, it only supports RGB (https://docs.gtk.org/gdk-pixbuf/property.Pixbuf.colorspace.html), and a JPG (or anything else, I assume) is probably converted...
I've also a trial fix for an annoyance I've been having, where the window geometry fails to be restored apparently at random. If this is not OK I can remove it or create a separate MR. Is that bug related to this MR? Did that behavior occur before any of the changes in this MR? As far as I can see it's unrelated to this MR and it did occur before the changes (but I didn't experience it as much as now that I've been opening/closing MComix multiple times...) The change is so small (basically just resizing...
I've figured out how to read an embedded profile from a pixbuf, so I'll try to rewrite this.
Thanks for the crash course. The intent, and to some extent the math, is relatively clear, but when it comes to when and how each profile should (or actually is) taken into account, I have the impression it's the wild west, and each program/library does whatever. I have put the preference in a new tab. For what it's worth, Gwenview has, as far as I can see, only two related settings: enable/disable color management, and select rendering intent (perceptual/relative colorimetric). I've also added a...
Thanks for the crash course. The intent, and to some extent the math, is relatively clear, but when it comes to when and how each profile should (or actually is) taken into account, I have the impression it's the wild west, and each program/library does whatever. I have put the preference in a new tab. For what it's worth, Gwenview has, as far as I can see, only two related settings: enable/disable color management, and select rendering intent (perceptual/relative colorimetric). I've also a trial...
Try to fix random failure to restore window geometry
Move preference to a new tab
Is it better now? Animations should now work as before (i.e. profile conversion is not available for animations), and toggling the preference should refresh all images. AVIF images do not work for me (Kubuntu 24.04) no matter what, so I cannot test that. Although they work with Gwenview and ImageMagick, so maybe it's just some Python module.
Thanks for the feedback. Unfortunately, no, I'm not knowledgeable in either Pillow or color management... I mean, I know enough to figure out that some CMYK images are displayed wrong, track it down to images with embedded profiles and find a way to apply/use the profile "on the fly" without re-encoding the image. But I still don't understand color profiles and their quirks. I'm not even sure "convert to sRGB" is right, since sRGB is a colorspace and not a profile. I'm quite lost here. Still, for...
Refresh images when toggling convert to sRGB and workaround for animations
Thanks for the feedback. Unfortunately, no, I'm not knowledgeable in either Pillow or color management... I mean, I know enough to figure out that some CMYK images are displayed wrong, track it down to images with embedded profiles and find a way to apply/use the profile "on the fly" without re-encoding the image. But I still don't understand color profiles and their quirks. I'm not even sure "convet to sRGB" is right, since sRGB is a colorspace and not a profile. I'm quite lost here. Still, for...
Thanks for the feedback. Unfortunately, no, I'm not knowledgeable in either Pillow or color management... I mean, I know enough to figure out that some CMYK images are displayed wrong, track it down to images with embedded profiles and find a way to apply/use the profile "on the fly" without re-encoding the image. But I still don't understand color profiles and their quirks. I'm not even sure "convet to sRGB" is right, since sRGB is a colorspace and not a profile. I'm quite lost here. Still, for...
MR https://sourceforge.net/p/mcomix/git/merge-requests/53/ implements this feature.
Add an option (in preferences dialog) to convert embedded profiles to sRGB
Add an option for converting embedded color profiles to sRGB
Support CMYK and color profile conversion
I wonder if this man was involved in the early TheoDORE development, or maybe he was just ahead of his time: https://www.findagrave.com/memorial/199617236/theodore-molden
Invalid UHF .lus file
The molden "specification" doesn't say anything about case sensitivity, but it mentions "[ATOMS]" while the example shows "[Atoms]" and, more significantly, molden itself opens files with uppercase "[MOLDEN FORMAT]" without complaint. I don't say Molcas should not or will not be changed, but I believe Jmol should be changed too.
It works without any directory, I just need to have a "TRD" directory, even if it's...
"TRD" directory needed, but unnecessary
Molden files with too many orbitals
Greek diacritics
no_files
Add :figname: option to the figure directive
:name: in figure adds an id to the <img> rather than the <div>
Well, I would suggest that something like: .. class:: myclass **Term 1** Definition...
Creating labels (hyperlink targets) in description items
It's not only loading, but also creating. To reproduce: File -> New database BibTeX...
It's not only loading, but also creating. To reproduce: File -> New database BibTeX...
wrong units from .geo.molden files