User Activity

  • Posted a comment on discussion Help on ffdshow

    Subtitle alignment commands are not supposed to persist beyond the current paragraph. Most players like VLC, MPlayer, MPV, etc obey this. But ffdshow is unique in allowing them to persist. This happens because ffdshow stores alignments etc in "TsubtitleParser::TsubtitleFormat::textformat" which acts as a persistent container for everything. There should be a reset of some of these at each parapraph. There is some awful difficult-to-understand and overly complex code involved.

  • Posted a comment on discussion Help on ffdshow

    In TsubtitleMixedProps.cpp there is a fake \move used to translate slider settings. Firstly the isSSA() condition should be removed because it usurps the IDFF_subSSAOverridePlacement parameter, and secondly such a fake {\move} prevents any subsequent alignment commands from being executed. Bad code.

  • Posted a comment on discussion Help on ffdshow

    In TsubtitleFormat.cpp there is an isAlignment variable that is used to prevent repeated application of {\aN} or {\aN}. There is no reason to do this.

  • Posted a comment on discussion Help on ffdshow

    In Tsubreader.cpp there is a wrong assignment when identifying subtitle files. The "HH:MM:SS.m,HH:MM:SS.m" is identified SUB_SUBRIP and the "HH:MM:SS,m --> HH:MM:SS,m" is identified as SUB_SUBVIEWER. These are both wrong and should be swapped around.

View All

Personal Data

Username:
j--w
Joined:
2019-10-27 23:08:36

Projects

  • No projects to display.

Personal Tools