Mihail Isakov

COMP: Update GDCM system version check for SetSecondaryCaptureImagePlaneModule

During conversion from implicit TS, GDCM sets VR of many (most) attributes VR::UN (unknown). I just tried converting from implicit TS and I can confirm this. Most likely, Horos was unable to cope with this at some point. CP-246

During conversion from implicit TS, GDCM sets VR of many (most) attributes VR::UN (unknown). I just tried converting from implicit TS and I can confirm this. Most likely, Horos was unable to cope with this at some point.

./gdcmconv -i JLSL_08_07_0_1F.dcm -o out.dcm -w -V will work if GDCM is compiled with the newer CharLS (GDCM_USE_SYSTEM_CHARLS), as well as the other JLSL_08_ files. Found charls version 2.4.1 r@deb2:~/gdcm2/build/bin$ ./gdcmconv -i ~/Downloads/DICOM/bad_jpegls/JLSL_08_07_0_1F.dcm -o out.dcm -w -V r@deb2:~/gdcm2/build/bin$ JLSL_16_08_0_1F.dcm seems to have wrong DICOM BitsAllocated, why it is 16, JPEGLS says bitsPerSample = 8. so the issue, not sure. I didn't look at 'sign' issue, BTW.

I have reproduces the change. I have done a (draft) PR https://github.com/malaterre/GDCM/pull/165 Do you have a suitable DICOM file? #include <iostream> #include <cstdint> #include <vector> int main() { const std::vector<unsigned short> a{ 7, 6, 5, 4, 3, 2, 1, 0 }; std::cout << "Old:" << '\n'; for (size_t x = 0; x < a.size(); ++x) { ////////////////////////////////////////////// // // int16_t nmask = (int16_t)0x8000; nmask = (int16_t)(nmask >> a.at(x)); // // //////////////////////////////////////////////...