Activity for Sebastian Pipping

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #110

    There is a patch attached to https://bugs.gentoo.org/637438 now. Please consider it for application here. Thanks!

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #110

    It also breaks compilation of khtml with error: /usr/include/gif_lib.h:248:51: error: declaration of ‘void* reallocarray(void*, size_t, size_t)’ has a different exception specifier reallocarray(void *optr, size_t nmemb, size_t size); The "other" reallocarray is from stdlib.h of glibc. The error above is from GCC 5.4.0.

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #110

    It also breaks compilation of khtml with error: /usr/include/gif_lib.h:248:51: error: declaration of ‘void* reallocarray(void*, size_t, size_t)’ has a different exception specifier reallocarray(void *optr, size_t nmemb, size_t size); The "other" reallocarray is from stdlib.h of glibc. The difference in exception specifier has to do with extern "C" I suppose. The error above is from GCC 5.4.0.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #110

    I also breaks compilation of khtml with error: /usr/include/gif_lib.h:248:51: error: declaration of ‘void* reallocarray(void*, size_t, size_t)’ has a different exception specifier reallocarray(void *optr, size_t nmemb, size_t size); The "other" reallocarray is from stdlib.h of glibc. The difference in exception specifier has to do with extern "C" I suppose. The error above is from GCC 5.4.0.

  • Sebastian Pipping Sebastian Pipping modified ticket #30

    Parser will not identify absolute URLs correctly

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #30

    Bug moved to GitHub: https://github.com/uriparser/uriparser/issues/2 Closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #32

    Query String Parser return wrong value

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #32

    Hi! I found this bug to be a duplicate of bug 12 (ex 3590761) now and to be fixed since uriparser 0.7.8 by commit abb4153da87117c3c14f3fd5fb5f7df148232b2e. This is what I did on the shell to find it: # git diff uriparser-0.7.5 master -- {lib,src}/UriQuery.c [..] # git blame -- src/UriQuery.c | fgrep 'if (walk + 1 <= afterLast) {' abb4153d src/UriQuery.c (Sebastian Pipping 2012-12-10 00:38:23 +0100 426) if (walk + 1 <= afterLast) { # git show abb4153d [..] # git tag --contains abb4153d | head -n 1...

  • Sebastian Pipping Sebastian Pipping modified ticket #32

    Query String Parser return wrong value

  • Sebastian Pipping Sebastian Pipping modified ticket #12

    Parsing fails when URL ends with empty query parameter value

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #30

    Hello Stefan, I recall that absolutePath only is set for URLs without a host present. So if it is a bug, you could check for presence of a host first, for a workaround. Best, Sebastian

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #30

    Hello Stefan, I recall that absolutePath only is set for URLs with a host present. So if it is a bug, you could check for presence of a host first, for a workaround. Best, Sebastian

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #32

    Hi Parteek, I cannot confirm that behavior with Git master. Please check this new test case and report back: https://sourceforge.net/p/uriparser/git/ci/4e87336dfb675fadd30c65cfc3a64d62c34c05d6/

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #69

    This issue got assigned CVE number CVE-2017-16938 in the meantime, so for reference: https://nvd.nist.gov/vuln/detail/CVE-2017-16938

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #65

    Adding CVE link https://nvd.nist.gov/vuln/detail/CVE-2017-1000229 for completeness.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #70

    Here's my take on a portable patch.

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #65

    Here's a patch candidate for review. Output with the patch applied from a Debian sid i386 chroot: $ ./src/optipng/optipng poc.tiff ** Processing: poc.tiff Error: Out of memory ** Status report 1 file(s) have been processed. 1 error(s) have been encountered.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #65

    Here's a patch candidate for review. Output with the patch applied form a Debian sid i386 chroot: $ ./src/optipng/optipng poc.tiff ** Processing: poc.tiff Error: Out of memory ** Status report 1 file(s) have been processed. 1 error(s) have been encountered.

  • Sebastian Pipping Sebastian Pipping created ticket #70

    pngxmem.c:37:32: warning: comparison is always false due to limited range of data type [-Wtype-limits]

  • Sebastian Pipping Sebastian Pipping modified a wiki page

    Home

  • Sebastian Pipping Sebastian Pipping posted a comment on a wiki page

    Hi Mrinal, you seem to be looking for XInclude (https://en.wikipedia.org/wiki/XInclude). Please note that Expat moved to GitHub. Fox XInclude, there is this ticket: https://github.com/libexpat/libexpat.github.io/issues/10

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #31

    Hi Nick, thanks for the report! Should be fixed by https://sourceforge.net/p/uriparser/git/ci/048fc15e1667b8d34fad5211f97e19d375b91fc0/ on Git master now. I'm happy to use your full realname in the change log for credit instead if you share it with me trough some channel. Best, Sebastian

  • Sebastian Pipping Sebastian Pipping modified ticket #31

    Max size of destination buffer in UriStringToWindowsFilename

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #515

    I had a closer look now and consider the cause outside of Expat, see https://github.com/libexpat/libexpat/issues/143#issuecomment-328603563 . Please re-open the ticket on GitHub with further details if my analysis seemed anything. Thanks!

  • Sebastian Pipping Sebastian Pipping modified ticket #515

    XML_ERROR_UNCLOSED_TOKEN when parse some Chinese characters

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #523

    A quick update: I searched and found MSDN documention on calling conventions now [1], found how to integrate an stdcall switch to CMake build systems for debugging [2], was then able to reproduce the problem on AppVeyor [3], tried that wrapper idea mentioned above (patch attached) and ran into more errors related to stdcall then [4]. So my impression is that cdecl is the only supported default calling convention at the moment and to support stdcall would need a bit more. Is that something you would...

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #531

    Thanks, Marc!

  • Sebastian Pipping Sebastian Pipping modified ticket #531

    XMLWF rejects XML file

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #523

    A quick update: I search and found MSDN documention on calling conventions now [1], found how to integrate an stdcall switch to CMake build systems for debugging [2], was then able to reproduce the problem on AppVeyor [3], tried that wrapper idea mentioned above (patch attached) and ran into more errors related to stdcall then [4]. So my impression is that cdecl is the only supported default calling convention at the moment and to support stdcall would need a bit more. Is that something you would...

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #523

    Hi Arno, but expat should at least compile with the stdcall switch With that said, I'm starting to understand now that we have these lines in Expat and they are the trouble ones: mtemp->malloc_fcn = malloc; mtemp->realloc_fcn = realloc; mtemp->free_fcn = free; I guess if we did a trick like #if defined(_MSC_VER) static void * _EXPAT_malloc(size_t size) { return malloc(size); } #else # define _EXPAT_malloc malloc #endif [..] mtemp->malloc_fcn = _EXPAT_malloc; it would work with either calling convention...

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #523

    Hi Arno, but expat should at least compile with the stdcall switch With that said, I'm starting to understand now that we have these lines in Expat and they are the trouble ones: mtemp->malloc_fcn = malloc; mtemp->realloc_fcn = realloc; mtemp->free_fcn = free; I guess if we did a trick like #if defined(_MSC_VER) static void _EXPAT_malloc(size_t size) { malloc(size); } #else # define _EXPAT_malloc malloc #endif [..] mtemp->malloc_fcn = _EXPAT_malloc; it would work with either calling convention at...

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #523

    Hi Arno, but expat should at least compile with the stdcall switch With that said, I'm starting to understand now that we have these lines in Expat and they are the trouble ones: mtemp->malloc_fcn = malloc; mtemp->realloc_fcn = realloc; mtemp->free_fcn = free; I guess if we did a trick like #if defined(_MSC_VER) static void _EXPAT_malloc(size_t size) { malloc(size); } #else # define _EXPAT_malloc malloc #endif [..] mtemp->malloc_fcn = _EXPAT_malloc; it would work with either calling convention at...

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #16

    Seems obsolete, closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #16

    predefined entities...

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #77

    Seems obsolete. If not, please provide a pull request at https://github.com/libexpat/libexpat , Closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #77

    Build issues on Symbian and BREW

  • Sebastian Pipping Sebastian Pipping modified ticket #89

    Fix cmake file to install libs in the right path on 64 bit systems

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #89

    No reply for a year, closing as obsolete.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #82

    Hi! There seem to be two main aspects here: Migration to GNU Automake and supporting Windows CE. For Automake, we use that on Git master by now. For Windows CE, if it still matters, please make a pull request against latest master on GitHub: https://github.com/libexpat/libexpat Thanks!

  • Sebastian Pipping Sebastian Pipping modified ticket #82

    New libtool, use automake, port to windows ce

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #92

    No reply for more than a year, closing as obsolete.

  • Sebastian Pipping Sebastian Pipping modified ticket #92

    Export a CMake Config file

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #87

    We have this code in by now: return (XML_Index)(parseEndByteIndex - (parseEndPtr - eventPtr)); If you still get warnings, please open a new ticket or pull request at GitHub: https://github.com/libexpat/libexpat/issues/

  • Sebastian Pipping Sebastian Pipping modified ticket #87

    Patch to prevent compiler warning when building for 64-bit

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #91

    I suppose this ticket is obsolete. If it's not, regarding the packaging team has request an email from the vendor stating that they will support the application if it has been packaged with App V no we don't, sorry; closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #91

    XML Parser packaged with APP V

  • Sebastian Pipping Sebastian Pipping modified ticket #74

    Files needed to build expat using VS2005

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #74

    We moved to vs2013 and CMake by now. CMake has a generator for vs2005, see https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html#visual-studio-generators . Closing as obsolete.

  • Sebastian Pipping Sebastian Pipping modified ticket #525

    XML_ERROR_INVALID_TOKEN on a legal xml character

  • Sebastian Pipping Sebastian Pipping modified ticket #505

    Infinite loop in lib/xmlparse.c:XML_GetBuffer

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #505

    This issue was fixed in the mean time: In 2.1.1: https://github.com/libexpat/libexpat/commit/ba0f9c3b40c264b8dd392e02a7a060a8fa54f032 In 2.2.0: https://github.com/libexpat/libexpat/commit/f0bec73b018caa07d3e75ec8dd967f3785d71bde Closing as fixed.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #515

    I have copied this bug report to GitHub now: https://github.com/libexpat/libexpat/issues/143

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #523

    Related: https://sourceforge.net/p/expat/feature-requests/1/

  • Sebastian Pipping Sebastian Pipping modified ticket #523

    explicit __cdecl for Microsoft Compilers: malloc/realloc/free

  • Sebastian Pipping Sebastian Pipping modified ticket #516

    Crash during fuzz testing with Expat 2.1.0 and 1.95.0: lookup

  • Sebastian Pipping Sebastian Pipping modified ticket #517

    Crash during fuzz testing in Expat 2.1.0: poolDestroy

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #523

    I guess that is relevant if you want to put pointers to the original malloc/realloc/free functions in there but not for self-made substitutes? If we change that calling convention we break ABI to my understanding. Also I assume that people would rather use this feature with functions other than the originals and if they tried, they would have noticed. Making a trivial wrapper would work as workaround, I suppose. To summarize, I believe this can be closed as "good enough" or "not worth the ABI break"....

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #531

    https://sourceforge.net/p/expat/bugs/525/ is related.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #525

    https://sourceforge.net/p/expat/bugs/531/ is related.

  • Sebastian Pipping Sebastian Pipping modified a comment on ticket #468

    According to http://pubs.opengroup.org/onlinepubs/009695399/basedefs/stddef.h.html type ptrdiff_t can be no bigger than long (but long can be bigger than int).

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #468

    According to http://pubs.opengroup.org/onlinepubs/009695399/basedefs/stddef.h.html type ptrdiff_t can be no bigger than long but long can be bigger than int.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #468

    For the record, a commit from that time would be 94cdbbb1db66e93045f7b1d61404793e2fdd885f and the mentioned pointer-diff-to-int-cast is this: charDataHandler(handlerArg, (XML_Char *)s, (int)((XML_Char *)next - (XML_Char *)s));

  • Sebastian Pipping Sebastian Pipping modified ticket #357

    xmlwf canonical output does not conform to the spec

  • Sebastian Pipping Sebastian Pipping modified ticket #292

    Support for XML 1.1

  • Sebastian Pipping Sebastian Pipping modified ticket #314

    no flag to control 64 or 32 bit libraries built

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #314

    Hi! If this ticket is still of interest, please re-open and help me understand why CFLAGS and LDFLAGS alone do not do the job. For now I'm closing as obsolete. Thanks!

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #334

    Linux solutions including Debian and Gentoo have addressed this problem by providing two libraries: libexpat.so and libexpatw.so (compiled with XML_UNICODE). It seems that approach is good enough, closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #334

    Create different link symbols for different XML_Char sizes

  • Sebastian Pipping Sebastian Pipping modified ticket #499

    randomness for hash fix not enough

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #500

    I'm assuming this to be in context of Gentoo. Sicne Gentoo has a solution to this problem by now, I'm closing this ticket as obsolete.

  • Sebastian Pipping Sebastian Pipping modified ticket #500

    Need pkg-config file for libexpatw (unicode)

  • Sebastian Pipping Sebastian Pipping modified ticket #508

    Turning off utf16 support

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #508

    In case this ticket is not obsolete and still of interest: For internal storage, Expat uses UTF-8, unless XML_UNICODE is defined (which switches to UTF-16). To disable support for parsing UTF-16, we would need to maintain a switch and keep both states working, wich duplicates some effort on Expat side. Also, the XML spec is rather clear that "All XML processors MUST accept the UTF-8 and UTF-16 encodings of Unicode" so that flag would make Expat not conform to the spec. I'm therefore closing as "not...

  • Sebastian Pipping Sebastian Pipping modified ticket #513

    Unable to compile under Visual Studio 2013 Preview

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #513

    Hi! Our current AppVeyor CI integration compiles the code with Visual Studio 2013 fine. if this is still an issue, please open a new ticket on GitHub: https://github.com/libexpat/libexpat . Thanks!

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #521

    This very bug has been fixed by https://github.com/libexpat/libexpat/commit/b47dbc9745932c160893d433220e462bd605f8cd by now but there may be more. For details please see the ticket at GitHub at https://github.com/libexpat/libexpat/issues/142 . Closing this ticket here as fixed.

  • Sebastian Pipping Sebastian Pipping modified ticket #521

    Binding memory leak when duplicate attributes error

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #524

    Done for a while now, closing as fixed.

  • Sebastian Pipping Sebastian Pipping modified ticket #524

    Redirecting expat.sourceforge.net to www.libexpat.org

  • Sebastian Pipping Sebastian Pipping modified ticket #529

    invalid left shift in xmltok_impl.c and xmltok.c

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #529

    Fixed since 2.2.0, commit https://github.com/libexpat/libexpat/commit/2106ee4050fd0d30e776e1c5a48937bb76a17074 , closing.

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #531

    Still valid for Expat 2.2.4. I notice the bug is marked as "private". Marc, any concerns about making it public now?

  • Sebastian Pipping Sebastian Pipping modified ticket #530

    ExpatMM link on libexpat.org needs UPDATING

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #530

    Finally updated, see https://libexpat.github.io/doc/bindings/. Closing as fixed.

  • Sebastian Pipping Sebastian Pipping modified ticket #542

    Theoretical issue in XML_Convert_Result

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #539

    Fixed since 2.2.1, commit https://github.com/libexpat/libexpat/commit/896b6c1fd3b842f377d1b62135dccf0a579cf65d , closing.

  • Sebastian Pipping Sebastian Pipping modified ticket #539

    Expat 2.2.0 doesn't support the XML tags larger than 15 characters in Unicode

  • Sebastian Pipping Sebastian Pipping modified ticket #542

    Theoretical issue in XML_Convert_Result

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #542

    Addressed by https://github.com/libexpat/libexpat/commit/448d79c02e1b670ca69a7606c048165ae8126076, closing. For more details, check the related ticket on GitHub, please.

  • Sebastian Pipping Sebastian Pipping created ticket #970

    Speed Dreams bundles vulnerable copy of Expat

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #542

    Hello Benbuck, thanks for your report. We're in the process of migrating to GitHub....

  • Sebastian Pipping Sebastian Pipping posted a comment on merge request #2

    I renamed the option from "BUILD_install" to "INSTALL" but the rest is unchanged....

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #534

    Looks fixed to me but feel free to re-open.

  • Sebastian Pipping Sebastian Pipping modified ticket #534

    Not building on win due to doc/xmlwf.1 not being present or generated

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #534

    I have added an extra "AND NOT MSVC" guard now. If that turns out too much, I'm happy...

  • Sebastian Pipping Sebastian Pipping posted a comment on ticket #534

    That patch is now in Git, thank you! I also used the ${PROJECT_SOURCE_DIR} idea to...

1 >