Activity for Jonas Hahnfeld
-
Jonas Hahnfeld posted a comment on ticket #4182
In case you can read this, I still haven't figured out the right way to disable write access...
-
Oh no, this should not have worked! Please use GitLab
-
output-distance: set device properties in batch driver file
-
commit d99780e93bfeafbcafce1c2653eac8e294057e84 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 9 11:49:03 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sun May 10 10:43:12 2020 +0200 output-distance: set device properties in batch driver file This fixes the output quality of the regtest results. Previously, the code sets a device by doing (png16m) finddevice this put a default device on the stack, ignoring the command-line arguments. To fix this, specify...
-
Remove define causing a warning
-
commit 3ba316af1f73395294df29ee34f3472df31b7e00 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Mon May 4 16:19:00 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Sat May 9 20:04:45 2020 +0200 Issue 5963: Remove define causing a warning These lines were added in commit 25beb8d01b in 2008 to provide compatibility with GCC 3.4 which clearly does not support C++11. (The warning is visible since commit b96b6334c0 which put system headers last, so that the define is already provided...
-
Add option to use Ghostscript API instead of forking
-
commit ddfd0b4fb548aa32bfd809014502de0666d514f3 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Mon Apr 27 20:54:43 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Sat May 9 20:04:45 2020 +0200 Issue 5949: Add option to use Ghostscript API instead of forking This is much more efficient than the current scheme when converting many PostScript files, for example when building the documentation. For the Notation Reference, lilypond-book now takes ~2m30s instead of 5m to compile...
-
Cosmetic fixes to accidental.cc
-
commit 4088a7813706aafd48dd551aa19d019970088412 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun May 3 20:55:05 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 9 11:28:51 2020 +0200 Cosmetic fixes to accidental.cc
-
SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on original data
-
commit 4860434b122611df632dfd9aaa21c430e4b67819 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 11:46:02 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 9 11:28:51 2020 +0200 Compute SVG skyline based on original data Since stencil data is used as input to formatting decisions, this will make SVG output more similar to PS/PDF output.
-
https://sourceforge.net/p/testlilyissues/issues/5940/ never was "push", it's currently in "review".
-
Use axis indexing to clarify different behaviors for X/Y skylines
-
output-distance: create PNG files in batch
-
commit 1c1d51861861e11f7f6ffe664fb471bececc7baf Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 14:25:13 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:13:27 2020 +0200 output-distance: create PNG files in batch
-
Use axis indexing to clarify different behaviors for X/Y skylines
-
commit 766070bdbcc1da6ac123f7003db5bf3ba073defd Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri May 1 19:59:30 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:04 2020 +0200 Use axis indexing to clarify different behaviors for X/Y skylines
-
Calculate skylines only once.
-
commit 750d6a547567409b6aa2d49bcb34912774aae4bc Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun Apr 26 15:39:01 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:16 2020 +0200 Calculate skylines only once. Before, Axis_group_interface::skyline_spacing() would call the function add_interior_skylines(), which recursed into VerticalAxisGroups. This caused staff-skylines to be computed twice: once as part of the Staff's VerticalAxisGroup, and once to...
-
Create skylines directly from glyph outlines.
-
commit 79ec62e686a95bbb8bb8b61a3dcbd702de0abb91 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 09:33:36 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:30 2020 +0200 Create skylines directly from glyph outlines. This avoids creating garbage for the intermediate Scheme data to transport the glyph outlines. a20f8b786e - Create skylines directly from glyph outlines. baseline: 267e894e79 Thread skyline construction through stencil interpretation...
-
Avoid using Skyline_pair::insert.
-
commit b872b327c471a9538d93fba21ff0385709aae2c2 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun May 3 20:31:10 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:55 2020 +0200 Avoid using Skyline_pair::insert. Skyline::insert(Box) creates a skyline and merges it. In this case, the boxes are non-overlapping, so it is trivial to create a skyline out of them. Remove Skyline::insert(). Using it repeatedly leads to a quadratic complexity, so it's best...
-
Convert stencil to skyline directly
-
commit 96b0e346adebe12ac742044c02cc8c2152e89977 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 09:31:13 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:13:08 2020 +0200 Convert stencil to skyline directly Gets rid of more intermediate storage. eb3e0449f4 - Convert stencil to skyline directly baseline: 78d4ae8627 Thread skyline construction through stencil interpretation args: -I carver MSDM memory: med diff -1464 (stddevs 202 98, n=3) memory:...
-
Build slur skyline out of segments rather than boxes.
-
commit 6d76be6462d3595851b0fe3c13ba238b5cdbbddf Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri May 1 09:09:24 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Mon May 4 22:45:35 2020 +0200 Build slur skyline out of segments rather than boxes. This provides more precise skylines. The regtest shows 11 images that changed, with tighter formatting for files involving slurs.
-
Use Scheme_hash_table for keyword handling
-
commit d4c4823e5e5c0e7481fd65e74b95b23ed78ff5d2 Author: David Kastrup <dak@gnu.org> AuthorDate: Mon Apr 27 13:52:54 2020 +0200 Commit: David Kastrup <dak@gnu.org> CommitDate: Sat May 2 11:32:54 2020 +0200 Issue 5946: Use Scheme_hash_table for keyword handling
-
Add option to use Ghostscript API instead of forking
-
rebase + allow -dgs-api=#f to still fork http://codereview.appspot.com/548030043
-
add license information http://codereview.appspot.com/548030043
-
Han-Wen, David, shall we close this as Issue 5946 is now in staging?
-
Add flag to NoteColumn using Axis_group_interface.
-
commit 0b45d764dcbc704713c8a32186561305e58d5659 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Mon Apr 27 10:31:56 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 2 09:25:34 2020 +0200 Add flag to NoteColumn using Axis_group_interface. The NoteColumn is an axis-group, for both X and Y axes.
-
Put system headers after lilypond headers throughout
-
commit b96b6334c00adb398b632aaeefdeaf3a8e6c57c5 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Mon Apr 27 10:22:26 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 2 09:26:12 2020 +0200 Put system headers after lilypond headers throughout
-
Thread skyline construction through stencil interpretation
-
commit 267e894e79fe5ce238c4db40f2a760511eead001 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat Apr 25 12:10:59 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 2 09:26:21 2020 +0200 Thread skyline construction through stencil interpretation
-
Add option to use Ghostscript API instead of forking
-
Add option to use Ghostscript API instead of forking http://codereview.appspot.com/548030043
-
Use axis indexing to clarify different behaviors for X/Y skylines
-
Refactor get/set_property to take the item as first argument
-
commit 550d0a4def00786bf7c7373101dced4c68ad893d Merge: eeea9423b2 42eaa5cb51 Author: David Kastrup <dak@gnu.org> AuthorDate: Thu Apr 30 14:24:06 2020 +0200 Commit: David Kastrup <dak@gnu.org> CommitDate: Thu Apr 30 14:24:06 2020 +0200 Merge branch 'issue5882' commit 42eaa5cb512a55451f7769d2880d304df92abe17 Author: David Kastrup <dak@gnu.org> AuthorDate: Tue Apr 7 10:48:24 2020 +0200 Commit: David Kastrup <dak@gnu.org> CommitDate: Thu Apr 30 14:19:17 2020 +0200 Issue 5882/3: Complete the set/get_property...
-
Use vectors rather than lists for skylines.
-
commit eaf40071f56ca2ca337dc7684c0da3f307f070bd Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri Apr 17 16:37:44 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 1 08:35:18 2020 +0200 Use vectors rather than lists for skylines. Linked lists have poor locality. This yields a ~7% speedup on the Carver MDSM score. [...]
-
Transform: add print_smob to aid debugging
-
commit 0a63bd48a02ccdaf7253b1e8edb83a44a6573293 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat Apr 25 13:09:24 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 1 08:35:08 2020 +0200 Transform: add print_smob to aid debugging
-
output-distance: print summary as final step
-
commit 7c94a65db633664a16998ebe121be0b786b4ab7d Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun Apr 26 10:53:13 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 1 08:34:51 2020 +0200 output-distance: print summary as final step Otherwise, summary results are obscured by "creating bla.png" messages
-
Did you regenerate configure? It should have complained about a missing dependency. On Ubuntu you need to install the libgs-dev package. Anyway after feedback from Han-Wen I will update the patch and guard this by an optional configure flag. So no need to re-test the current Patch Set.
-
Fix warnings related to po
-
pushed to staging as commit eeea9423b22a3c7cd481fe4f481e56fd15381097 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Thu Apr 23 16:40:43 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Thu Apr 30 12:09:44 2020 +0200 Issue 5932/2: Inline po-* targets into po/ Documentation/po/ has a custom po-update. Also drop po-changes, it's only spamming the output when running po-update. commit 8a98c1ddfdda31eac4e43704e72309e558399bef Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate:...
-
Documentation: Remove deprecated skeleton-update
-
pushed to staging as commit 934244a57c9535db9e8133361aacab783acd29e4 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Sun Apr 19 16:47:29 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Tue Apr 28 19:59:28 2020 +0200 Issue 5921: Documentation: Remove deprecated skeleton-update It's been like that since commit 858e506c2a in 2010, ten years ago. Also remove target all-translations-update which cannot have worked since the same time and update some CG pages mentioning the targets...
-
Make dblatex an optional dependency
-
pushed to staging as commit 250d841a51ebfdf44f4f62ce34a547e275eec62d Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Mon Apr 20 18:13:44 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Tue Apr 28 18:30:51 2020 +0200 Issue 5930: Make dblatex an optional dependency Commit cfa910f1c1 in 2012 made it required unless disabling the doc build. This is an overapproximation since dblatex is only required for compiling the DocBook result of running lilypond-book on the file input/regression/lilypond-book/suffix-lyxml.lyxml....
-
stepmake: Remove defunct test template
-
pushed to staging as commit 15dc3368e4258ec1011db230411afacfb044f245 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Sun Apr 19 16:26:11 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Tue Apr 28 18:30:17 2020 +0200 Issue 5929: stepmake: Remove defunct test template It was inlined into flower/ with commit 719b9352fd.
-
Use binary search in Axis_group_interface::combine_pure_heights.
-
Obviate method_finder methods
-
Make GET_LISTENER take a pointer arg and deduce its type
-
Hm, actually I had some comments yesterday that have not been addressed yet.
-
Remove unnecessary includes of dispatcher.hh
-
Don't use C++ operator synonym "not"
-
Use binary search in Axis_group_interface::combine_pure_heights.
-
(note that Fixed_2_21_1 could be wrong, depending on how this version is released) commit 7d4ddb25cec526d9785aa041bdb1d499d3209333 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Mon Apr 20 10:31:30 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sun Apr 26 12:36:47 2020 +0200 Use binary search in Axis_group_interface::combine_pure_heights. This used linear search, probably making the cost quadratic in the score size In the Carver MSDM score, this function accounts...
-
From the logs, it's one of the lilypond-book processes in Documentation, didn't test myself though. Did you try to run 'make doc' on your end? As the change is removing ly:lexer-keywords it could also be that it breaks generation of the internals reference manual.
-
Use vectors rather than lists for skylines.
-
resetting to trigger testing of Patch Set 9
-
Use vectors rather than lists for skylines.
-
still a duplicate of #5896
-
I'll let this patch sit in 'Push' for another countdown in case somebody wants to chime in...
-
Fix font-name-add-files.ly on GUILE v2
-
marking as pushed / fixed commit 30c845d383bf2c85b75f2c2be735837e59a224d0 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat Apr 25 10:49:40 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat Apr 25 13:20:58 2020 +0200 Fix font-name-add-files.ly on GUILE v2
-
drop po-changes http://codereview.appspot.com/551830043
-
make_draw_bezier_boxes: save work if thickness == 0.0
-
commit fadb710df7ed135d7712ce50fcdfa83a89753213 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri Apr 17 20:20:50 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri Apr 24 00:09:01 2020 +0200 make_draw_bezier_boxes: save work if thickness == 0.0 This drop make_draw_bezier_boxes from 0.73% to 0.44% in the profile for MSDM
-
Execute build scripts directly from source
-
commit 4234d8e962caf5d148b57402715d7ebb08931bf1 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Wed Apr 15 21:51:33 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Thu Apr 23 13:13:38 2020 +0200 Issue 5909/3: Execute build scripts directly from source The only meaningful substitutions used by scripts/build are @PERL@ and @PYTHON@. This can be moved to the invocation, getting rid of many dependencies across directories. commit e6a2669cbc709d59647fc8743b75eef2d666df5d Author:...
-
stepmake: Remove unused tex template
-
commit f65e29d24f4a3d2cdf32d2d41e49e0b0b1ff8511 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Sat Apr 18 12:47:33 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Thu Apr 23 13:14:37 2020 +0200 Issue 5918: stepmake: Remove unused tex template The build system never invokes these rules.
-
Hide two unused debugging methods, NFCI.
-
[AArch64/ARM] Fix two compiler warnings in InstructionSelector, NFCI
-
[Support] Treat truncation of fullpath as error
-
[ELF] Fix GCC8 warnings about "fall through", NFCI
-
stencil-integral: factor out repeated scm_car(expr) calls
-
commit 04a6a4ac56bddff2ccf53cf3004f1d93b0a16a9a Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri Apr 17 13:38:09 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Tue Apr 21 19:30:54 2020 +0200 stencil-integral: factor out repeated scm_car(expr) calls
-
midi: convert data to bigendian encoding directly
-
commit f51b4dbe635670cc08789daa0d9670f60fa47423 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri Apr 17 14:23:58 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Tue Apr 21 19:30:43 2020 +0200 midi: convert data to bigendian encoding directly Before, the MIDI code would encode data as a hex string, to convert it binary afterwards. Shortcut this process.
-
Fix comment for Box::unite
-
commit ad341ffbcd6fbdcff7cea43a370b2b8a30b6f2b6 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri Apr 17 18:59:47 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Tue Apr 21 19:30:31 2020 +0200 Fix comment for Box::unite
-
Use a hash table for the lexer keywords
-
@lilypond-pkx could you please try again? The error you saw should now be fixed in master.
-
Web: update documentation symlinks, and use https in RewriteRules
-
Documentation: Add dependency notation.texi -> internals.texi
-
Documentation: Add dependency notation.texi -> internals.texi
-
pushed to unbreak patch testing commit 338f83af6e9014042cf7266e82e8cfa852e89ebb Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Tue Apr 21 09:21:40 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Tue Apr 21 11:04:55 2020 +0200 Documentation: Add dependency notation.texi -> internals.texi notation.tely includes, via notation/notation-appendices.itely, many generated files (like markup-commands.tely). These are the result of processing ly/generate-documentation.ly for intern...
-
I had the same glitch recently: I pushed a counted down patch and set it to 'Fixed', unsetting the 'Patch' field. After refreshing, it was 'Started' and 'new'. I guess this is a bug in SF? Edit: For reference, here's the link: https://sourceforge.net/p/testlilyissues/issues/5910/#e352 But looks like I was successful with setting to review here?
1 >