Jad Altahan

Thanks for the suggestions -- I figured a quick workaround using the dialog result. For anyone coming across this issue, it basically breaks down to this: bool canPromptModifyRO; void ConfirmModifyProtectedFile() { // (dialog setup code here) if (dlgResult == YES) { // (remove RO flag here) canPromptModifyRO = false; } canPromptModifyRO = true; } void HandleNotifications() { case ModifyAttemptRO: // SCN_MODIFYATTEMPTRO if (!canPromptModifyRO) ConfirmModifyProtectedFile(); break; case CharAdded: //...

It's a regression caused by f6b4d0.

In the GIF, I set a breakpoint at void Document::NotifyModifyAttempt(), debugged SciTE, and tried to just insert a character in the read-only buffer. Here is the important bit from the call stack: SciTE.exe!Scintilla::Document::NotifyModifyAttempt() Line 2396 SciTE.exe!Scintilla::Document::CheckReadOnly() Line 1159 SciTE.exe!Scintilla::Document::InsertString(int position, const char * s, int insertLength) Line 1213 Scintilla attempts to insert the character I pressed, but checks if the buffer is...

SCN_MODIFYATTEMPTRO multi fires when there's selection

I was actually thinking about V support in Scintilla a week ago. I looked at some V code from their repository and it seems that it is heavily influenced by Go. V and Go are both are both brace-based languages. Wouldn't it be more viable to extend the CPP lexer to meet the requirements of these language rather than write a new one?

Thanks for the info. Code Analysis were showing the file clean until I selected "C++ Core Check Rules" rule set in the project's Properties dialog in VS2019. Please ignore the original patch. The attached is a fresh one. Also, could you please change the ticket title to "Resolve some Core Guidelines warnings in Nim lexer" ?

[PATCH] In Nim lexer, constexpr & noexcept where appropriate

I have patches for OP's request; however, I should also mention that functions are part of CMake 3, which added more new features to the scripting language (see #1270). Our lexer does not currently have any of the new goodies.