Activity for GaryT
-
GaryT modified a comment on discussion Open Discussion
I can have a look and see if I can at least reproduce. I did get a leaflet based 'version'/option sort-of working, if that would be of interest. It would be hopefully relatively easy (assuming I can remember what I did) to hack it into your system - less so to do a "proper" version that works out of the box. There's issues with bits of google maps specific code in odd places (presumably the refactoring that Tomasz referred to), and potentially a legal/moral issue of having 'googlemaps' hardcoded...
-
I can have a look and see if I can at least reproduce. I did get a leaflet based 'version'/option sort-of working, if that would be of interest. It would be hopefully relatively easy (assuming I can remember what I did) to hack it into your system - less so to do a "proper" version that works out of the box. There's issues with bits of google maps specific code in odd places (presumably the refactoring that Tomasz referred to), and potentially a legal/moral issue of having 'googlemaps' hardcoded...
-
Sorry. Yes it is fixed. I thought I had edited my comment after posting it. I'm happy to close this one if you are.
-
Well I'm listening, and impressed. Whereas I've never been a professional programmer. But I learnt Pascal at school using marksense cards, and went out specially to buy a B5 pencil that would make a readable mark with just one stroke. And I used to run a machine at work that ran on a PDP-8 that had an intermittent core memory fault. That meant that I had to reload the papertape bootstrap routine on the front panel toggle switches fairly regularly. I used to know those 20-odd codes off by heart: 6014,6011,7375......
-
I just noticed a couple of minor comment typos in class_reportbase.php: 254 /aproxiamte/approximate/ 256 /Stationary/Stationery/ 708 /alignement/alignment/ 715 /carachter/character/ Would it be easier if I learnt to generate a patch file? In terms of the PDOException, I did a bit of googling on the error, and it seems it may be postgresql specific. e.g. https://github.com/querydsl/querydsl/issues/2443 - they just suggest "it can be resolved by adding the order by expression to the select clause"....
-
I'm still getting the PDOException If it helps, I think the offending query is: SELECT DISTINCT 'INDI' AS type, i_id AS xref, i_file AS ged_id, i_gedcom AS gedrec, i_isdead, i_sex FROM pgv_individuals JOIN pgv_dates AS filter1 ON (filter1.d_file=i_file AND filter1.d_gid=i_id) JOIN pgv_dates AS filter2 ON (filter2.d_file=i_file AND filter2.d_gid=i_id) WHERE i_file=1 AND filter1.d_fact='CHAN' AND filter1.d_julianday2<=2459595 AND filter2.d_fact='CHAN' AND filter2.d_julianday1>=2459565 ORDER BY fil...
-
I'm still getting the PDOException If it helps, I think the query is: SELECT DISTINCT 'INDI' AS type, i_id AS xref, i_file AS ged_id, i_gedcom AS gedrec, i_isdead, i_sex FROM pgv_individuals JOIN pgv_dates AS filter1 ON (filter1.d_file=i_file AND filter1.d_gid=i_id) JOIN pgv_dates AS filter2 ON (filter2.d_file=i_file AND filter2.d_gid=i_id) WHERE i_file=1 AND filter1.d_fact='CHAN' AND filter1.d_julianday2<=2459595 AND filter2.d_fact='CHAN' AND filter2.d_julianday1>=2459565 ORDER BY filter1.d_jul...
-
Parse error: syntax error, unexpected variable "$ascii_langs", expecting "," or ";" in V:\phpGedView\includes\classes\class_reportbase.php on line 45 Looks like a missing semicolon on the line above. I added one, and that fixed the error.
-
I should have recorded my test conditions! But most of those seem to have worked, thanks. Address labels seem to be fixed. Close relatives report - pdf: ERROR 2: Undefined array key "showSourcesPresent" 0 Error occurred on line 1 of file class_reportbase.php(2865) : eval()'d code in function eval 1 called from line 2865 of file class_reportbase.php in function PGVRifSHandler 2 called from line 1476 of file class_reportbase.php in function startElement 3 called from in function xml_parse 4 called...
-
I should have recorded my test conditions! But most of those seem to have worked, thanks. Address labels seem to be fixed. Close relatives report - pdf: ERROR 2: Undefined array key "showSourcesPresent" 0 Error occurred on line 1 of file class_reportbase.php(2865) : eval()'d code in function eval 1 called from line 2865 of file class_reportbase.php in function PGVRifSHandler 2 called from line 1476 of file class_reportbase.php in function startElement 3 called from in function xml_parse 4 called...
-
Gerry: sorry, yes. That's exactly what I just worked out just now too. Thanks. FWIW that code seems to be used in many reports - the first 3 I tried at least.
-
@Tomasz - you're right about 'nothing'. I had assumed that it was comparing two values, and previously it was doing something like eval($foo != null) and changing null to '' made it eval($foo != ), which is why I changed it to 0 instead. I'm certainly not an experienced php programmer, but at least the errors went away, and it went on to generate what looked like a correct report. I'll try to do some debugging and get some details
-
I'll try to do some debugging and get some details
-
I noticed this exact bug a while back too. I'm working on a alternative map to google, so I'm trying to get up to speed with the code in this module I'll have another look at this and see if I can find what's going on.
-
I've been hunting down deprecation errors, and learning functions at the same time. I got a whole lot of errors when I selected reports/address labels/pdf. At first I thought I had an issue with the updated tcpdf library, but then I thought I would try it with my official server that's running a slightly older svn version, and older php as well, and I got the same errors. ERROR 2: Undefined array key "showid" 0 Error occurred on line 1 of file class_reportbase.php(2865) : eval()'d code in function...
-
PHP 8.1.1 deprecations - Take 5
-
It looks like you missed the $ off $addname on line 2195 of reportbase.php I fixed that, but then got: Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in \includes\classes\class_reportbase.php on line 2249 Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in \includes\classes\class_reportbase.php on line 495 Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in \includes\classes\class_reportbase.php...
-
I have to admit I've made an effort to go round testing various modules to try to find the warnings, so hopefully can get this nightmare over ASAP. Please let me know if you'd prefer I don't. Might it be possible to find more of these with a regular expression? And explicitly - Thanks!
-
I have to admit I've made an effort to go round testing various modules to try to find the warnings, so hopefully can get this nightmare over ASAP. Please let me know if you'd prefer I don't. Might it be possible to find more of these with a regular expression?
-
PHP 8.1.1 deprecations - Take 4
-
Sorry, it's our summer holidays here, so it has been a little difficult to keep up. ~~~ Fatal error: Uncaught Error: Call to a member function GetAge() on null in C:\Users\OEM\Documents\phpgedview-svn-r7322-trunk-phpGedView\includes\classes\class_date.php:1246 Stack trace: 0 C:\Users\OEM\Documents\phpgedview-svn-r7322-trunk-phpGedView\includes\functions\functions_print.php(2033): GedcomDate::GetAgeYears(Object(GedcomDate), Object(GedcomDate)) 1 C:\Users\OEM\Documents\phpgedview-svn-r7322-trunk-phpGedView\includes\functions\functions_print.php(2114):...
-
Thanks, unfortunately you were right: ( I take it subsequent problems such as this should go here until this lot is fixed?) ERROR 2: Attempt to read property "minJD" on null 0 Error occurred on line 1214 of file class_date.php in function MinJD 1 called from line 1295 of file class_date.php in function Compare 2 called from line 2166 of file functions_print.php in function format_fact_date 3 called from line 332 of file class_event.php in function print_simple_fact 4 called from line 203 of file...
-
php 8.1.1 deprecation warnings part 2
-
Yes. That seems to have worked. Thanks.
-
Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in C:\Users\OEM\Documents\phpgedview-svn-r7322-trunk-phpGedView\includes\functions\functions_print.php on line 867
-
And another: Deprecated: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated in C:\Users\OEM\Documents\phpgedview-svn-r7322-trunk-phpGedView\includes\classes\class_menu.php on line 90
-
Deprecated: str_replace()
-
Running under the latest Google maps API, this line of code is broken again. It looks like viewport.f.b etc are no longer supported in the current API. I got my installation to at least work by changing the same line (currently 690) to this: zoomlevel = Math.round(Math.log(Math.abs(360 / (place.geometry.viewport.getNorthEast().lat - place.geometry.viewport.getSouthWest().lat) )) / Math.LN2) - 2; I must admit I assumed the calculation is based on latitude - longitude doesn't seem to make sense, and...
-
One good aspect of "You are not welcome here." - it can be incentive to take a break. I have a location with a Question mark, and it's in the top level if that matters. I viewed the top level in place hierarchy, and clicked on the location with the ? - this normally gives me a list of individuals with that place. Instantly not welcome. Luckily I think I know who it is.
-
Great. Thanks Gerry. The logic seems a bit odd to me with my very limited php. When you go into the page you get this URL .../module.php?mod=googlemap&pgvaction=places&parent=0 if you click the 'view' button without it being ticked you get: .../module.php?mod=googlemap&pgvaction=places&parent=0&display= if you tick the box, and click 'view', the URL stays the same, but you get the view of inactive places. if you untick the box, and press view, the URL becomes ...//module.php?mod=googlemap&pgvaction=places&parent=16367&display=inactive...
-
I've now updated to an SVN snapshot including all the modules, so hopefully this is a current, reproduceable issue... I've noticed that in the "Edit geographic place locations" page, it appears you can't untick the tickbox that enables viewing inactive locations. I've since realised that I think I can work-around the problem by editing the URL of the page, which works, but is a bit ugly. I had a quick look at the code, but that bit looks a bit beyond me.
-
Now that I realise I was using the wrong version of googlemaps, I can't be sure if it was a bug or my fault.
-
I'm an idiot. I think I downloaded the Googlemap module from 4.2 rather than 4.3...
-
@Tomasz - No, I don't think the issue is the card for me. I've just signed up, and added a card. There were suggestions on the Google page that new API keys don't work with V2 either. The idea of another map source is a good one. I'm familiar with UMP, but I don't think the mapping is worldwide enough. OSM is a good suggestion, but I think the issue there is finding a server. I was thinking about doing a local test of a V2->V3 conversion. My skills aren't great, but I can make a start. Would it make...
-
I'm trying to get the googlemaps module to work, and came across a possible major snag. I looked at my browser console log, to find some hints as to why I'm still getting a greyed out map, and saw this: The Google Maps JavaScript API v2 is deprecated and will be turned off on May 26, 2021. That's pretty soon :(
-
I didn't know anything about collations. I've learnt something. I delved into the tables. It turns out the pgv_placelocation tables varchars had utf8_unicode_ci collations and the pgv_places varchars were utf_general_ci. I changed the collation on the places database and the error went away. Perhaps the collations weren't explicitly specified when the tables were created?
-
Thanks Gerry. Did you mean the setting "Use the database to provide UTF-8 collation"? That was set to 'no'. I realise the first $200 is free. But there's nothing to say that might suddenly go away. $200/month is a lot of $$$. I guess it's also a lot of data, and unlikely unless I get hacked.
-
I've finally managed to install the googlemaps module, but I'm still having a couple of issues: The first is that I'm a little nervous about setting up a billing account to do so. Hopefully I'll get my head around that eventually. The second is that that came as a bit of a surprise as there is no mention of billing in the Wiki. I guess that could do with updating. Would that be something I could help with? There's also no details about what the key needs to do. I guess it would make sense to restrict...
-
I want to fork off a gedcom for my partners's family, as her sister will be mostly working on it. Is there a way to start off a new gedcom from my partner, and automatically link her in? Or do I just have to copy her information into the new one? (apologies - I didn't see the 'translations' forum line. Admin please feel free to move - I can't see anywhere I can)
-
I want to fork off a gedcom for my partners's family, as her sister will be mostly working on it. Is there a way to start off a new gedcom from my partner, and automatically link her in? Or do I just have to copy her information into the new one?
-
I've had PGV installed on hostmonster for several years, and it recently stopped...
1