Activity for Florian Richter
-
Florian Richter posted a comment on ticket #96
renaming the argument from value to val is now commited :) Thx!
-
rename value to val so it is not shadowing the member variable
-
rename value to val so it is not shadowing the member variable
-
VS2015 fixes and make Function::IsNull() const
-
fix: scsprintf needs the buffer size parameter with VS2015 and fix the sizeof difference with wchar_t
-
make Function::IsNull() const
-
Yes. Will commit the patches soon.
-
fix: some strings are missing _SC()
-
- fix: some strings are missing _SC()
-
Var<SQChar*>::Var(HSQUIRRELVM vm, SQInteger idx) : "const SQChar* ret = value;" needs to use a reference with a const cast (like it did before) or it will always be null see : https://stackoverflow.com/questions/32779079/c-why-cant-we-convert-char-to-const-char On Var::push() renaming the argument from value to var should be done in more cases (still has the same name as the member variable "T* const value" in many places) HSQOBJECT obj is already initialized with sq_getstackobj() in Var::Var(HSQUIRRELVM...
-
Some strings are missing _SC()
-
Function::IsNull() should be const
-
I'm actually not using it but had it on an old todo :) I think the VS static analysis reported it Completely forgot: scsprintf needs the size parameter with VS2015 scsprintf(buf, 512, _SC("%s:%d:%d: %s"), source, (int) line, (int) column, desc);
-
I'm actually not using it but had it on an old todo :) I think the VS static analysis reported it
-
sizeof difference with wchar_t
-
Just tested it a bit more. "drawable" is always set as a string, so it's never null....
-
Thanks! Everything works but only without this change : Var(HSQUIRRELVM vm, SQInteger...
-
Error checking removes functionality in ClassType::GetInstance()
-
SharedPtr constructor doesn't always initialize correctly
1