Eli Schwartz

Compilation fails when autotools is not installed.

Building flightgear with LTO fails due to ODR violation

I can't try current trunk as it doesn't build since [r14858]. Regenerating the autotools now breaks once it hits that directory. No time to investigate tonight.

I'm agreeing that the change from a couple months ago is a good fix, because I backported it to: https://downloads.sourceforge.net/xsb/XSB-4-0-0.tar.gz (with additional patches from https://dev.gentoo.org/~keri/distfiles/xsb/xsb-4.0.0-gentoo-patchset-3.tar.gz) I haven't tried building from git, no.

I'm agreeing that the change from a couple months ago is a good fix, because I backported it to: https://downloads.sourceforge.net/xsb/XSB-4-0-0.tar.gz (with additional patches from https://dev.gentoo.org/~keri/distfiles/xsb/xsb-4.0.0-gentoo-patchset-3.tar.gz) I haven't tried building from git, no.

Unfortunately after backporting the patches, it still fails: -e [x86_64-pc-linux-gnu-gcc] loader_xsb.c using -fPIC -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types -Wno-error=format-security loader_xsb.c: In function ‘get_index_tab’: loader_xsb.c:136:16:...

Oh hrm right, fixed by edce993d1a837707781dbd4b5025e22e694c9053.

Note that implicit-function-declaration is tied to https://sourceforge.net/p/xsb/bugs/265/ This is an easy case because you can just include the header you forgot. Some Modern C errors are a lot harder to fix.