Rafael Odzakow

smf: update PR with information about faster upgrade [#2017]

That would work. As long as it is possible to rollback the campaign it is fine. On 10/20/2017 03:18 PM, Alex Jones wrote: I understand the intention. It makes sense. One of the other solutions I had considered is to put a check at the beginning of SmfCampaign::initExecution(). If the campaign state is EXECUTION_COMPLETED, then just return. What is the point of reexecuting a campaign that already completed? Are you OK with that? [tickets:#2648] https://sourceforge.net/p/opensaf/tickets/2648/ smf:...

A rollback will not work if a unexpected cluster-reboot was done before PBE was enabled. SMF looses its runtime data in that case, so your patch would cause issues for rollback. The intention is to be able to test the system and then decide to proceed with rollback or commit. That means reboots are allowed once the campaign is completed together with rollback. I think the issue you are having needs a solution preferably in SMF but I'm not sure how that would look yet.

I can not comment on moving restorePbe to commit for now. But a SMF rollback is what is used to undo the campaign operations. A reboot would only clear changed IMM data if PBE was off. That leaves software and CLI operations, which would cause incompatibilities. A rollback has to be planned for in a campaign and does not handle errors. So by default SMF takes a backup before starting a campaign to be able to recover.

smf: refactor smfd folders [#2633]

smf: refactor smfd folders

smf: refactor smfd directory structure

smf: Node by node upgrade