Not entirely sure about the tags I have assigned to the bug, actually I'm almost sure I have set them wrong - I checked that in the latest 7.5.0 release.
Wrong order "Left / Right" for the Active Area dialog in Italian
Hey there David, this is great news! Sorry for the very late reply. My tests so far are all fine, thanks a lot for the time you took to release it! Cheers
Indeed "crosswise" and "inline" are far better than "minor" and "major" in this context. I found the log "Fixed bug in ELLIPSA2 (start angle did not work correct)" (whatever that means) in the attached changelog for MSWLogo 6.0h, which I found somewhere on the internet, but that doesn't help much about tracking where and how things went wrong with that procedure. It only confirms that the misbehaving ELLIPSA2 procedure is out since a long time. If ELLIPSEARC2 isn't going to get fixed anytime soon,...
Thanks for opening that bug for me, I've subscribed to it.
Very good, I've updated my local repo and tested it, works fine now. Just so you know, I've asked about the start of the italian training courses: it should be around September the 15th 2017, it would be great if you find the time to release FMSLogo 7.2.0 for that date.
This is a very neat addition, well done! By the way, I've noticed that it works in both the command line and the editor: if you open it from the command line and then open the editor with the keyboard shortcut, the dropdown for the first autocompletion stays visible and actually overlays on the editor.
Italian localization of SLOWDRAW doesn't affect localized movements
Sorry for reopening this bug over and over again, but I noticed that the way translations get extracted from the startup-1040.logoscript file I've modified for fixing RALLENTA end up creating multiple entries in the translation tables of the manual - for example, FD maps 4 times, twice to A, once to FORWARD and once to AVANTI, the same happens with BK, I, BACK and INDIETRO
Attached the setup\fmslogo.nsi updated file, I've translated some english strings and also fixed an already translated string that didn't match the actual english version, hopefully this time the patch file will be okay :)
For some reason the file you attached shows all blank pages for me.. I believe this is due to "the mark of the Web", [...] that marks potentially dangerous content (like HTML) [...] you can remove the mark by right-clicking and going to the file's properties. Ah, yes, removing that mark let me see the contents of your version, thanks for pointing that out. For me, FMSLogo has the worst experience of any project that I've worked on. Well, you did a terrific job on easing other's life for building...
Neat, thanks for committing the latest version. I'm also glad to read that my style in writing that Logo procedure is fine.
For some reason the file you attached shows all blank pages for me... I've rebuilt it with my setup and I can open my version, but don't ask me why, I have no idea - disregard the version that appears in the first page, I've altered it just to make sure I had a clean marker to distinguish my builds from yours. As for the approach, it looks fine to me, having separate pages for each table is cleaner and lighter. I would just eventually add some links right after the appendix name that points to the...
Neat, I actually managed to install cygwin, fop, wxwidgets, build wxwidgets using your .sh file, checkout the FMSLogo repo with SVN and build pretty much all of it... even with a not really recent laptop I managed to do all in a handful of hours total. Your how-to install file reports the wrong cygwin website I think (or maybe they changed that lately) by the way. Also, if fop is necessary, it may be stated there. Now I can fiddle with some further improvements I would like to propose, this time...
Reopened for fixing the bug I introduced with reusing SLOWDRAW inside of RALLENTA, please see the attached patch in this comment above.
Italian localization of SLOWDRAW doesn't affect localized movements
Reopened for fixing the bug I introduced with reusing SLOWDRAW inside of RALLENTA, please see the attached patch in my latest comment
I will implement it the way you suggested, overwriting SLOWDRAW completely for Italian as Daniel Ajoy did for Spanish Uhm... I didnt't really realize that those were actually two different approaches... I ended up overwriting SLOWDRAW and COPYDEFing RALLENTA to it. The attached patch applies to the latest version I've took out from the current sourcebase and operates on both the italian and english versions of the forward / back movements, so that now SLOWDRAW and RALLENTA will be completely interchangeable....
David: I thought it would be useful to include a visual of the color in the translation tables I noticed that you have already committed the perl script for generating those colors and all the actual images, that's a great idea. the English names are not particularly useful (for example, DodgerBlue only means something to the people who follow American Baseball) When I was translating the color names I've researched a bit on each color and I found out that there is a dedicated italian wiki page exactly...
Indeed, the way I implemented it calling SLOWDRAW within RALLENTA makes them not equivalent and causes the misbehavior you pointed out. Since you've already committed that version, though, I will provide a further patch against the current version of startup-1040.logoscript and I will implement it the way you suggested, overwriting SLOWDRAW completely for Italian as Daniel Ajoy did for Spanish. And, yes, I was wondering why we had those commented out COPYDEFs in the localized strartup scripts......
I've checked the UCBLogo manual from this link: https://sourceforge.net/p/ucblogo/code/HEAD/tree/docs/usermanual.pdf as far as I can see there is not even a direct command named after circles (one should rely on the ARC command) and the same stands for ellipses (it could be eventually achieved with the SETSCRUNCH command combined with the ARC command, which by the way would achieve same the angle behavior I've explained in my patches above and which is what the C++ NODE lellipsearc(NODE arg) command...
Replacement for ELLIPSEARC2 wrong behavior + documentation improvements
Here is the hopefully correct version of the proposed ELLIPSEARC2 implementation. I suspect the code could be simplified, I'm not sure I really need to separately target the different orientations of the ellipses, the code seems to perform fine though. I would be more than happy if anybody more knowledgeable than me about these geometric issues could improve it further.
ooops... I got the slope calculation wrong for one of the orientations of the ellipse... attached to this post is the fixed testcase, follows patch for the Library file with the fixed bug
David, I'm adding some further improvements to the translation file (see attached patch) I fixed a typo "Colonre" -> "Colore", replaced all occurrences of "workspace" with "Spazio di Lavoro" (for coherence with preexisting "spaziolavoro" mentions), added a translation for "Fight Multiple Sclerosis" and finally added self-credit for my contribution :) By the way, thanks a lot for crediting me in your latest commits. I look forward for when you'll have the time to see the bugs and patches I've reported...
David, I'm adding some further improvements to the translation file (see attached patch) I fixed a typo "Colonre" -> "Colore", replaced all occurrences of "workspace" with "Spazio di Lavoro" (for coherence with preexisting "spaziolavoro" mentions), added a translation for "Fight Multiple Sclerosis" and finally added self-credit for my contribution :) By the way, thanks a lot for crediting me in your latest commits. I look forward for when you'll have the time to see the bugs and patches I've reported...
Patch to improve the documentation relative to ELLIPSE2 - the way it is worded right now has the axis orientation wrong.
Patch to improve the documentation relative to ELLIPSEARC2. The way it is worded now suggests leaving the start angle set to zero, which is not needed. The proposed improvement provides an example of how to build an ellipse out of multiple arcs and explains in detail how FMSLogo performs the the drawing, including the calculation of the arc's angles (which could be a bit unintuitive, as the angles appear as being computed on a circle and then stretched to fit the ellipse)
Patch to improve the documentation relative of ELLIPSE2 - the way it is worded right now has the axis orientation wrong.
Patch to replace ELLIPSEARC2 file in the Logolib folder
Replacement for ELLIPSEARC2 wrong behavior + documentation improvements
Replacement for ELLIPSEARC2 wrong behavior + documentation improvements
I'm not 100% sure that putting the translated colors in the graphics section would be the best course of action... I've checked that section just because I know English and I already knew about that section. A better solution would be to append them to the existing tables in the A and B appendices, so that a non-english user can reach them easily without having to thumb through the manual. The best solution would eventually be to create two further dedicated appendices to output just the colors'...
I'm not 100% sure that putting the translated colors in the graphics section would be the best course of action... I've checked that section just because I know English and I already knew about that section. A better solution would be to append them to the existing tables in the A and B appendices, so that a non-english user can reach them easily without having to thumb through the manual. The best solution would eventually be to create two further dedicated appendices to output just the colors'...
Italian localization of SLOWDRAW doesn't affect localized movements
I forgot to bury the newly created RALLENTA procedure, and once I'm there, I'd like to add a couple of COPYDEFs for the missing ELLIPSE, ELLIPSE2 and ELLIPSEARC2. See the new attached patch please.
Italian localization of SLOWDRAW doesn't affect localized movements
File>Open... and File>New lose definitions from startup.logoscript
Oh, for some reason I thought that the section "Using color" in the .chm file would have been updated with the translated color names, but I guess it would not make much sense there among all the english texts... instead it would be good to have either two further pages "Colors: English to (other language)", "Colors: (other language) to English" added to the .chm file or having an additional COLORLIST procedure added to the Logolib folder that could list all available colors directly from code. Ideally,...
Oh, for some reason I thought that the section "Using color" in the .chm file would have been updated with the translated color names, but I guess it would not make much sense there among all the english texts... instead it would be good to have either two further pages "Colors: English to (other language)", "Colors: (other language) to English" added to the .chm file or having an additional COLORLIB procedure added to the Logolib folder that could list all available colors directly from code. Ideally,...
Thanks a lot for accepting my patch and for rebuilding the .chm file David, I'll use it to doublecheck the entire list of commands and verify if anything is really missing there as I mentioned earlier.
Hello David, you're welcome, it's my pleasure to help if I can. I would open the issue right now but there are still a couple of things I don't get: you mention that it's easier for people to state in which version they found the problem, but there is no dropdown item for version 7.1.0 - which is where I found it - the higher version I can target there is 6.29.X, should I simply target the higher version possible or should I test all the versions to find where the bug appeared or the alike? I'm completely...
Hello David, thanks for your feedback and of course thanks a lot for maintaining FMSLogo, which is an invaluable educational tool. Not sure I got that right though: is it fine to propose patches here in the forum or should I open an issue in the tracker? By the way, yes, now I see the "Add attachments" link here below. That may very well be that I completely overlooked it :) I wanted to ask you another thing: in the italian translations there is no need for a double version of the "gray / grey" color,...
Hello everybody, sorry for continuing to post stuff here as I'm not sure how and where exactly to post these messages. I've updated the italian translations in a couple of files, there doesn't seem to be any option to attach files here so I'm putting them on my website: startup-1040.logoscript.diff localizedstrings-it.h.diff I think that the automatically generated tables in the .chm files are missing some items but I wasn't able to doublecheck that, so I'll eventually create a new post sometimes....
Hello everybody, I'm posting this here because I'm not really sure it's a bug or not, and even if it was a bug, the bug tracker doesn't seem to have the appropriate milestones for reporting it. I am running FMSLogo version 7.1.0, italian version. Whenever I select "Nuovo" or "Apri..." from the "File" menu (I believe they correspond to the "New" and "Open..." english version) I lose all the COPYDEFs that appear in startup.logoscript, for example: launch FMSLogo issue command "MOSTRA PENNA" ("SHOW...