XMP: Fix repeats
XMP: Fix repeats
XMP: Add missing gap from XMP protocol
The nabble link doesn't work but this appears to be the same thread: http://developer.intra2net.com/mailarchive/html/libftdi/2016/msg00001.html (archive: https://web.archive.org/web/20180115232835/http://developer.intra2net.com/mailarchive/html/libftdi/2016/msg00001.html ) There's an unresolved question in that thread about whether that was a counterfeit chip, but I could easily believe that a genuine FTDI chip has weird undocumented clock behaviour in bit-bang mode (see my experience with FT232R:...
I also was affected by this bug. To summarize: The sigalarm used for scheduling repeat signals was racy with lircd's main poll loop. The symptom was: A 2nd irsend (hot on the heels of the 1st irsend) would hang (gdb showed lircd was in poll), until you sent a 3rd irsend (and then both the 2nd & 3rd irsends would be processed). I could only reproduce it with drivers/plugins that block while each signal is being sent, such as the kernel driver (I was using pwm-ir-tx) — I couldn't reproduce it with...
I also was affected by this bug. To summarize: The sigalarm used for scheduling repeat signals was racy with lircd's main poll loop. The symptom was: A 2nd irsend (hot on the heels of the 1st irsend) would hang (gdb showed lircd was in poll), until you sent a 3rd irsend (and then both the 2nd & 3rd irsends would be processed). I could only reproduce it with drivers/plugins that block while each signal is being sent, such as the kernel driver (I was using pwm-ir-tx) — I couldn't reproduce it with...
I also was affected by this bug. To summarize: The sigalarm used for scheduling repeat signals could interrupt lircd's main poll loop. The symptom was: A 2nd irsend (hot on the heels of the 1st irsend) would hang (gdb showed lircd was in poll), until you sent a 3rd irsend (and then both the 2nd & 3rd irsends would be processed). I could only reproduce it with drivers/plugins that block while each signal is being sent, such as the kernel driver (I was using pwm-ir-tx) — I couldn't reproduce it with...
Never mind, someone else already did just that (in 2018! https://sourceforge.net/p/lirc/tickets/315/#0719 — I wish I had found that 6 months ago) and you merged it recently in #50. Thanks again (for reviewing both mine & @asunxx's patches).
Thanks @seanyoung! If you have the appetite for more merge requests, there's #43, and we also have a patch (not yet rebased/submitted) that removes sigalarm altogether in favour of ppoll, which fixes a race condition when sending a 2nd irsend immediately after an irsend that has a repeat signal.
Fix repeat timer calculation
plugins: ftdi: Remove unused `time_left` function
Fix repeat timer calculation
plugins: ftdi: Remove unused `time_left` function
Fix sleep before sending next signal
plugins: ftdi: Remove unused `time_left` function
Fix calculation of how long we need to sleep before sending next repeat
We've been using this patch for years: https://github.com/stb-tester/lirc/commit/f9493fed34cc6d2de91921bfd650997552340ff4
lircd, lib: Add release_mask config option
lircd: Add release_mask config option
test: Add simple integration test for sending signals with lircd
test: test the new release_mask config option
test_release_mask: Add tests for send_start + send_stop
Yes, this commit (328f515, in lirc 0.10.0) breaks the ftdi driver for IR blasters using the FT232R chip (unless you specify old-timings:1 to use the old behaviour). Why does the FT232R run at the wrong rate? This could be due to libftdi not setting up the chip properly [...] The FT232R in bit-bang mode is buggy & jittery. Only a few specific baud rates work at all, but even then, the actual rate you get doesn't match the rate you asked for, as you noticed. Even with the best supported baud rate the...
Yes, this commit (328f515, in lirc 0.10.0) breaks the ftdi driver for IR blasters using the FT232R chip. Why does the FT232R run at the wrong rate? This could be due to libftdi not setting up the chip properly [...] The FT232R in bit-bang mode is buggy & jittery. Only a few specific baud rates work at all, but even then, the actual rate you get doesn't match the rate you asked for, as you noticed. Even with the best supported baud rate the output is jittery, leading to "missed keypresses" (where...
I have tested Will's patch second patch ("0001-plugins-ftdi-Specify-duty_cycle-to-fix-ftdi-driver.patch"...