David Faure

Pass QDebug by value to operator<<

Pass QDebug by value to operator<<

Also, based on the initial discussion, don't forget to set -DQT_NO_DEBUG_OUTPUT in release mode so that the performance penalty of debug statements is completely removed: diff --git i/CMakeLists.txt w/CMakeLists.txt index 793259b9d..d3830ec6f 100644 --- i/CMakeLists.txt +++ w/CMakeLists.txt @@ -67,7 +67,7 @@ endif() # Compiler defines if(CMAKE_BUILD_TYPE STREQUAL "Release") - add_definitions(-DNDEBUG -DBUILD_RELEASE -DNO_TIMING) + add_definitions(-DNDEBUG -DBUILD_RELEASE -DNO_TIMING -DQT_NO_DEBUG_OUTPUT)...

Rosegarden fails to start when jackd can't be launched

Re-tested today. After the above output, it repeats the last two lines 3 more times, and then it says jack server is not running or cannot be started and moves on. I see no changes in rosegarden related to this so I'm assuming it was a libjack update which changed this. We can close this bug report.

Works nicely for me, thanks.

Sorry for the delay in my reply (I was travelling). I confirm that things work as expected now. Thanks!

Oh! I just noticed the date in that last comment, it's much older than I thought. I see that the code has been changed since, to use QWidget::screen(), ignore me :-)