dcb

Given this C++ code: include <string></string> include <vector></vector> using namespace std; void f( string a) { } void g( vector < string > b) { } then cppcheck says the same thing for both functions: apr18b.cc:9:16: performance: Function parameter 'a' should be passed by const reference. [passedByValue] void f( string a) ^ apr18b.cc:13:27: performance: Function parameter 'b' should be passed by const reference. [passedByValue] void g( vector < string > b) Since copying a vector of strings will...

Option 2, please. I am happy to report bugs, but I don't do pull requests.

I found a message that looks slightly wrong. trunk $ grep "There was critical" lib/*.cpp lib/checkersreport.cpp: fout << "There was critical errors (" << criticalErrors << ")" << std::endl; trunk $ In proper English, "There was" with plurals should be "There were".

Hello there, The bug remains unfixed after three years, so I won't bother resubmitting it. Regards David Binderman From: bugs@tn5250.p.re.sourceforge.net bugs@tn5250.p.re.sourceforge.net on behalf of Kevin Adler kadler@users.sourceforge.net Sent: 17 October 2023 13:14 To: [tn5250:bugs] 46@bugs.tn5250.p.re.sourceforge.net Subject: [tn5250:bugs] #46 session.c:2949: bad compare ? status: open --> wont-fix Comment: Hi, if you are still experiencing this problem, please open an issue at https://github.com/tn5250/tn5250/issues...

The bug remains unfixed after three years, so it seems pretty pointless to resubmit it. A fix looks unlikely.

I haven't seen your CI before, so it can be no surprise that I see no evidence of a build by gcc or clang from today in it. I tried a git pull, just in case something had changed during the day. It didn't help. I have a self generated fix, so cppcheck builds for me here. I think that's about as far as I want to go with this. Thanks for your help.

$ git diff lib/settings.cpp diff --git a/lib/settings.cpp b/lib/settings.cpp index 896341a..7b62612 100644 --- a/lib/settings.cpp +++ b/lib/settings.cpp @@ -24,6 +24,7 @@ #include <fstream></fstream> #include "json.h" +#include "timer.h" std::atomic<bool> Settings::mTerminated;</bool> So I think lib/settings.cpp is up to date. In your CI, which C++ compiler do you use ? Perhaps Microsoft ?

Yesterday's cppcheck built fine. Not today. A compile error about SHOWTIME_NONE lib/settings.cpp: In constructor ‘Settings::Settings()’: lib/settings.cpp:69:30: error: ‘SHOWTIME_NONE’ is not a member of ‘SHOWTIME_MODES’ 69 | showtime(SHOWTIME_MODES::SHOWTIME_NONE), | ^~~~~~~~~~~~~ clang and g++ refuse to compile it, so I have no idea which compiler accepted the code. I ran the preprocessor only and grepped for SHOWTIME: $ grep SHOWTIME /tmp/q.ii enum class SHOWTIME_MODES; SHOWTIME_MODES showtime{};...