Activity for Diggory Hardy
-
Diggory Hardy posted a comment on discussion Open Discussion
Sounds good. Somehow I missed that when searching for test vectors, so maybe a couple of pointers in the documentation would be useful!
-
Hello, for my purposes, a few short tests within the code would suffice; see for example here. Call me opinionated if you like, but in my view code which is not obviously right/wrong should include self-tests (even if purely testing for consistency).
-
Since this appears to be the primary distribution point for the SFC generators, it would be appropriate I think if test vectors could be included in the distribution. This allows verification of third-party implementations. I notice it is mentioned somewhere that these are not "frozen", however they do not appear to have seen much revision recently. Adding a version number and re-creating the test vectors on each breaking change is not a big deal, I think.
-
Should mention this doesn't cause any problems when building with GCC.
-
patch: fix linking when using Clang compiler
-
Should be committed. I ended up reproducing exactly the same patch.
1