Joerg Werner

Some special cases not handled correctly when resolving URLs

First of all, thanks for the quick fix, Ronald! With respect to BrowserVersion, I agree that probably no one will really need to customize the setup of a certain browser version except for the header configuration. It may even be advantageous to make BrowserVersion immutable (solves the issue of BrowserVersion as map key). But then the header customization must be possible elsewhere, for example in WebClientOptions. This is of course a breaking change and maybe there is another way. But whatever...

I noticed that BrowserVersion objects are also used as key in hash maps. So messing around with the writable fields of BrowserVersion may lead to undesired effects, such as entries not found or creating additional entries for each modification. Not sure if resorting to the base browser type (nick) as key would be a solution.

Added test case.

Wrong JS engine setup in case of modified browser version

Dafür sind wir doch da ... ;-)

See also the attached patch that adds some test cases and tries to fix this issue.

Base URL may be wrong