Kevin Barry

Fix style issues https://codereview.appspot.com/554030043

Fix texidoc style issues in cross-staff-stem-offset.ly https://codereview.appspot.com/554030043

Hi James, A git formatted patch should be attached to this email. Kevin On Thu, May 07, 2020 at 01:13:29PM -0000, pkx166h wrote: No this is not automatic, Can you attach git formatted patch based on current master and attach it here, someone will push it for you. or you can ask for commit access as per: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commit-access

Does this get done automatically? (I don't have permissions to push). On Thu, May 07, 2020 at 08:52:10AM -0000, pkx166h wrote: Patch: countdown --> push Comment: Patch counted down - please push

Issue 4182: avoid checking the offset of cross-staff stems too early Calculating the 'X-offset of a cross-staff Stem too early causes the Stem's 'direction property to be accessed while it is still "calculation-in-progress" - always returning "UP". This causes the X-offset to be set incorrectly when the eventual stem direction will be "DOWN". This problem occurs in the scenario where the X-offset of a notehead is calculated early, when NoteHead::stem_x_shift calls Stem::calc_positioning_done (via...

The reason Han-Wen's patch won't apply is because it is based on other ongoing work (https://codereview.appspot.com/555760043/). It will not apply until that work is merged. My patch, if included, would have forced him to rebase that work, so this will save him some work at the cost of waiting longer for a fix for this issue to be available. His patch will replace mine so my work can be discarded.

Issue 5954: update OOoLilyPond info in usage manual OOoLilyPond is in active development, contrary to what is stated in the usage manual. Update the description accordingly. Update the link to point to the current webpage. https://codereview.appspot.com/583840059

Remove regression test https://codereview.appspot.com/582010043