Activity for Kevin Barry
-
Kevin Barry posted a comment on ticket #4182
Fix style issues https://codereview.appspot.com/554030043
-
Fix texidoc style issues in cross-staff-stem-offset.ly https://codereview.appspot.com/554030043
-
Hi James, A git formatted patch should be attached to this email. Kevin On Thu, May 07, 2020 at 01:13:29PM -0000, pkx166h wrote: No this is not automatic, Can you attach git formatted patch based on current master and attach it here, someone will push it for you. or you can ask for commit access as per: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commit-access
-
Does this get done automatically? (I don't have permissions to push). On Thu, May 07, 2020 at 08:52:10AM -0000, pkx166h wrote: Patch: countdown --> push Comment: Patch counted down - please push
-
Issue 4182: avoid checking the offset of cross-staff stems too early Calculating the 'X-offset of a cross-staff Stem too early causes the Stem's 'direction property to be accessed while it is still "calculation-in-progress" - always returning "UP". This causes the X-offset to be set incorrectly when the eventual stem direction will be "DOWN". This problem occurs in the scenario where the X-offset of a notehead is calculated early, when NoteHead::stem_x_shift calls Stem::calc_positioning_done (via...
-
The reason Han-Wen's patch won't apply is because it is based on other ongoing work (https://codereview.appspot.com/555760043/). It will not apply until that work is merged. My patch, if included, would have forced him to rebase that work, so this will save him some work at the cost of waiting longer for a fix for this issue to be available. His patch will replace mine so my work can be discarded.
-
Issue 5954: update OOoLilyPond info in usage manual OOoLilyPond is in active development, contrary to what is stated in the usage manual. Update the description accordingly. Update the link to point to the current webpage. https://codereview.appspot.com/583840059
-
Remove regression test https://codereview.appspot.com/582010043
-
This is due to the regression test, which uses the SVG backend. It looks like there isn't currently a way to do regression tests on the SVG backend (there is only one other regression test that does, and it was disabled in 2008). I will remove the regression test.
-
Issue 3778: Use bounding box as skylines for markup in svg backend As there is no routine for determining skylines for utf-8-string stencils, they normally fall back to the grob's bounding box, which is fine. However, when there is a mixture of utf-8-string and other types of stencil (which have associated skyline functions) in a single grob, the entire grob gets a skyline determined only from the non-utf-8-string stencils. This sometimes causes the text portion of such mixed grobs (e.g. metronome...
-
If you undefine out the warning then it will be printed when the backend is svg because the stencil expression is "utf-8-string" not "glyph-string". There is no routing for handling this type of stencil expression, so either a routing needs to be added or something went wrong before this point that resulted in this expression arriving in this form or at this place.
1