Task bar missing in latest trunk
Thanks, Mike and Sebastien! I do most of my teaching in C++ and Python these days, so I'm not as comfortable debugging Java code. I tried pulling this into NetBeans to see if I could get a good trace, but I'm afraid I'm just not comfortable enough in the interface to be able to figure out how to determine why the pointer is null. I tried putting an assert in, but it didn't behave the way I expected. I'm happy to take any advice that might help narrow this down. We're about a week away from final...
Here is a patch to fix the issue.
Map Editor won't generate empty maps in latest trunk
Oh. You may not be able to apply that without also applying this, which fixes a different issue with the tooltip:
Checking whether value is null seems to fix the issue. Here is a patch.
Checking whether value is null seems to fix the issue. Here is a patch.
I take that back. I was looking at the wrong file. There's actually a very useful NPE in my log file:
I take that back. I was looking at the wrong file. There's actually a very useful NPE in my log file:
I've duplicated this on several different Linux systems (at work and home). My freecol.log file doesn't seem to show anything relevant. :-(
Hmm. The problems seems to be in the following line of PlayerTable.java (line 196: Utility.localizeToolTip(box, StringTemplate .key(nationState.getShortDescriptionKey())); If I remove the call to nationState.getShortDescriptionKey() (for example, by replacing it with "Hello World") everything works fine. But if I put it back in, the game freeses when changing the availability of a plery.
It looks like that commit (16ed8d...) added "extend JLabel" to the AvailableCellRenderer class. Making them JLabels led to the behavior that they don't disappear when something is selected.
The other issue, the interface glitch seems to step from commit 16ed8d1f0e8b4765d93777f6a0aeed598023e2ff (Mass Message Renaming).
git bisect identifies commit: 0c4a7d05511c15017421216e72340ec9621cd72a as the culprit for the "not being able to start the game" part of this bug. Testing confirms that the previous commit works (well, you still have to click "Start Game" twice) while that one doesn't. The commit seems to reorder statements in the exception handling for "ReceivingThread" in the network code. That seems fairly removed from the particular symptoms I'm seeing, so I suspect that this change is only indirectly responsible...
There seem to possibly be two related issues. In some commits, clicking on the dropdown to select "Not Available" creates a graphics artifact where the dropdown menu does not close after selecting an option. However, when this happens it is still possible to start a game by clicking "Start Game" twice. However in others, the delayed closing of the dropdown coincides with some sort of race condition or infinite loop that prevents the game from starting at all.
I checked out 0.11.5 from git and rebuilt it with "ant clean && ant" and I still get the same behavior.
However commit a62e021e0eff1f0fb9037a71e62f294cd9033b95 works as expected.
However commit a62e021e0 works as expected.
I checked out 0.11.5 from git and rebuilding and I still get the same behavior.
FreeCol freezes after changing availability of nations
This bug still occurs for me in latest trunk. However, if I revert part of patch f937e46346b5272bfa184ecf4b3d779f02439f, it works again (hurrah for git bisect).
Hmm. I'm afraid I'm not sure what steps to try next. I'm just not familiar enough...
So I tried my hand in making a patch for this. I wound up with something that compiles...