InDllSecur.c, you use lstrcatW for concatenting strings. There's no need for this, which catches SEH exceptions too. Use wcscat or wcscat_s instead.
Aha! Now we're getting somewhere. In that file the code is: ``` #ifndef _AFX typedef CAtlStringW CStringW; ifdef _ATL_USE_WINAPI_FAMILY_DESKTOP_APP typedef CAtlStringA CStringA; endif // _ATL_USE_WINAPI_FAMILY_DESKTOP_APP typedef CAtlString CString; endif `` However, since I'm plugging this into a mostly MFC application (because I hate MFC),_AFXis defined. In the long run, this should be fixed, but in the meantime, should I just#undef _AFX` (or will that break everything else?)
ATL CString issues
Need ability to handle much longer strings
potentially uninitialized local variable in FilterBank
Debugging symbols for ffdshow?
MAYBE using uninitialized memory in hunspell:497
Using uninitialized memory in hunspell.cxx:452 (related to local variable shadowing in #273)
Possible NULL pointer dereference in hunspell.cxx:616
Local variable shadowing in hunspell.cxx:442
Realloc leak in hunspell.cxx:1504
Realloc leak in hunspell.cxx:337
If it makes you feel better, I had trouble reproducing this with the POC, and subsequently...
This issue (#19) is a known issue. See https://github.com/donho/notepad-plus-plus/issues/19...
A few other rules that I've thought of while writing patch 662. continue list here:...
TinyXml component of changes in #662
Non-mutilated version:
The list of changes that I'd been preparing - formatting slightly mutilated by sourceforge:...
I've decided to split this patch into many smaller patches, as it's far too large....
Ah, ok, cool. I'm just happy to be able to contribute :)
WAIT A SECOND THERE'S A GITHUB REPO??!?? Grr. Do you accept PR's on GitHub? Why didn't...
(reserved) Major patch, now compiles cleanly without _CRT_SECURE_NO_WARNINGS, and many other improvements
Actually I was wrong that vc120_xp "doesn't support any of them", it supports all...
Give me a few minutes while I tear my hair out, run around screaming, scare small...
WAIT A SECOND I TAKE THAT LAST BIT BACK There's a generic_string PathAppend(generic_string...
It's really eye opening, although it DOES NOT seem to detect the (mistake) of calling...
Yeah, so, Microsoft realized that Windows enjoys the reputation of the software running...
Short answer: Yes.
Here it is.
Created a build configuration for static analysis support
Here's the proper, TortoiseSVN compatible, patch.
Are there any debugging symbols? I'm asking on behalf of: https://sourceforge.ne...
This is kinda funny, I actually ran into a similar issue in doOpen, almost a year...
I'm sorry to be pushy/impatient, but could someone grep for doOpen?
As a side note: MAX_PATH isn't actually that maximum size of an NTFS path, but the...
I'm away from home until the 25th, so I can't fix it immediately, but we need to...
doOpen needs to be totally refactored, it's too fragile - fixing bugs breaks legitimate...
*AHHHHH this all makes sense now!*
Can you tell me more about that file? Attributes? Contents? Can you open it in windows...
I assume this worked before 1352?
It'd probably be a good idea to log something on doOpen's failure.
For reference: http://svn.tuxfamily.org/viewvc.cgi/notepadplus_repository/trunk/PowerEditor/src/NppIO.cpp?r1=1351&r2=1352&pathrev=1352&diff_format=u...
Grr. Posting from my phone is very frustrating.
Change summary: 1. Fixed operator precedence confusion for ::CheckMenuItem in Notepad_plus::command(int...
Change summary: 1. Fixed operator precedence confusion for ::CheckMenuItem in Notepad_plus::command(int...
Yeah, I totally stole that from Google's C++ style guide :) Side note: I learned...
Yeah, I totally stole that from Google's C++ style guide :) Side note: I learned...
Yeah, this actually seems to no longer be a problem. You can close/ignore this and...