Activity for Andrew Simpson
-
Andrew Simpson committed [b25ff9] on Code
Changelog
-
Transactions do not work with MySQL with DDL commands.
-
Update copyrights.
-
Token not verifying correctly since last edit.
-
Add session key defined constant.
-
Change to mb_scrub() for validation.
-
Bugfix: Don't show private usergroups in drop down menu
-
Changelog
-
Add more rigorous status checking.
-
Remove redundant row call.
-
Add missing data entry to prevent 'not null' errors.
-
Add missing data entry to prevent 'not null' errors.
-
Add missing data entry to prevent 'not null' errors.
-
White space cleaning
-
Update version number.
-
Update copyrights
-
Changelog
-
Private is a reserved word in PHP8.
-
create_function() is removed in PHP8.
-
Changelog
-
Aaah... 'relative path'. No, it has to be an absolute path. There will be something before the /www. Even though your relative root is /www, that is not the absolute root. Sorry, not SE, I meant SELinux. It limits access by programs to certain areas only. I don't think that is your problem.
-
Hmmm... it's the same problem as the previous posts. The code now checks for 'PHPInfo file_uploads On -> On', and gives a different error message. So that must be working. The next check is whether '/www/webcollab/files/filebase', exists and is writable. This check is failing. Are you sure that this is the correct path? No typos? And, can the webserver write to this path? Something like SE blocking the path?
-
Bugfix: Type cast 'real' is deprecated in PHP 7.4
-
O.K. the two file attached go into [webcollab-folder]/tasks folder and replace the existing files of the same name. The change is trivial; the type cast '(real)' is changed to '(float)'. (There are also some cosmetic formatting changes since the last release, because I patched against my working tree (not the last release)).
-
Thanks for the report. I'll need to patch the file and upload - will be tomorrow. Looks like the same error will occur with task listing. In the short term the error message is harmless and won't affect the program. If you want to suppress the message (until the patched file), temporarily raise the error reporting in PHP config file.
-
Is this with calendar or todo? I've actually been quietly looking at this, though it got a bit more complicated. I could not find much wrong with todo, but I found some 'bad' code in calendar. Not buggy code, just poor logic in the code. The calendar code has not been touched for a while and looked fairly messy. So I've ended up doing some major refactoring and efficiency improvements a couple of weeks ago. I did some comparison testing and todo and calendar were consistent with each other. I'll...
-
Refactor code.
-
Refactor code for readability.
-
Minor edits
-
Remove check for 'no globalaccess' based on
-
Update copyrights
-
Minor edits for code readability.
-
Changelog
-
Yes, I've given enough information that I'm sure you could get someone to assist you with remote access. I provide support via the forums (and bug reports). Generally this is enough to get most problems resolved.
-
Go to the file mentioned above: [webcollab]/config/config.php, where [webcollab] is the directory containing WebCollab files. Use a text editor to change the 'USE_EMAIL' value. The file installs with the value set right, so I would suspect that it's been changed at some time. You have to use a text editor. It can't be set within the program.
-
I see. You are missing part of the page because email is set to 'off'. In the file [webcollab]/config/config.php, look for this and make sure email is 'on' ("Y") //EMAIL CONFIGURATION //enable email to send messages? (Values are "Y" or "N"). // default is "Y". define('USE_EMAIL', "Y" );
-
Are you getting an error message when users send emails? If so, turn on debugging in [webcollab]/config/config.php /ERROR DEBUGGER //If an error occurs, who do you want the error to be mailed to ? define('EMAIL_ERROR', "" ); //show full debugging messages on the screen when errors occur (values are "N", or "Y") define('DEBUG', "Y" ); Doing this will show, on the screen, all the mail server 'chatter' during the mail sending. If there is no log shown (and no mail received), then either there was no...
-
The required email addresses are all obtained by a database call. The user names are in the same database table, so could be pulled at the same time (You would have to strip the surname to give only the first name). The issue would be as you say, for multiple users. In this case, an array of email addresses is created with a single message, then sent as a single email (to multiple recipients). To send individualised emails, separate emails would need to be sent, one for each user. Since the software...
-
Thanks for the error message. That does help, it's a bug. Attached file should fix the problem. However it's an embarrassing bug; according to Git this bug was added in 2015 - 6 years ago. I'll change my testing to cover this area better in future. The file replaces the same file in [webcollab]/tasks/. It's a one line change.
-
Bugfix: Type error in array (Thanks to Norm Lang)
-
Agreed, it should be the same. A quick look at the code reveals it is indeed similar. I will have to dig a bit deeper.
-
Was your software created through a forking? Yes, the original software was called CORE Project Management. You can still find this on Sourceforge, though it has been untouched since 2002. If so, when was it forked and was there a reason? It was forked in 2002. See the Changelog in the GIT directory. Basically, I started using CORE for projects at work - it did what I wanted - and in time became a contributor and developer. However the lead developer wanted to move in a different direction - which...
-
Hmmm 2.11 looks like around 2007. Are you running the UTF-8 version? Only important if you are using a language other than English. Do you currently have a MySQL database with innodb tables. The modern versions are all innodb and won't read the old tables (obsolete in MySQL). You can dump the database by using the bash script in [webcollab]/db. This is a text file that you can edit. If necessary add ENGINE = innodb to make the tables restore as innodb. Look at the schema files in the same directory...
-
Sounds good. I am just on holiday at present, so I will look further when I return to base in a few days.
-
Hi, I have been away in a remote area - no internet, no cellphone coverage for a few days. I haven't come across non-public schema, but looking at them very briefly, I would have thought you can do it by changing permissions on the database. SQL commands that should help? GRANT USAGE ON SCHEMA ALTER SCHEMA You would have to make sure that the webcollab user has the correct permissions.
-
Oh, actually I meant the git repo on this (Sourceforge) site: https://sourceforge.net/p/webcollab/code/ci/master/tree/ I've also updated the github repo as well. It doesn't get a lot of attention, so I tend to forget about it. There is a note on the front page directing to the Sourceforge page.
-
Yes, it's been added to the Git repo. I've also started preparing for a release, since there are enough changes to make this worthwhile.
-
Thanks. That's great. Have checked and added to the Git Repository. Also updated & corrected the language code for the HTML from se --> sv.
-
Update README.
-
Correct corrupted characters (Thanls Jan Roos)
-
Changelog
-
Oh, looks like my bad. The original translator gave me a file in 2005 which was in ISO-8859-1, The å character shows in that file. In 2011, I've converted the file to UTF-8. Probably used iconv, or something similar. However the å character has become corrupted. Not being a Swedish speaker, I was not aware. Can you check, if there is any other issues?
-
Yes, the language files are in [webcollab]/lang. The main Swedish translation files all start with se. There are three files, one each for short messages, long messages and email messages. For the help files, they are in [webcollab]/help, and there are two files starting with se_. All the files are in UTF-8. It is important to edit them with a UTF-8 capable editor. There is a README file in [webcollab]/lang which looks to be very outdated. I will update that file. The current file talks about IS0-8859-1,...
-
Interesting idea. I'll have a look at the code. Adding the project name should be relatively straightforward, but there prpbably needs to be another database call. Adding tasks and subtasks gets more tricky. To make the code more versatile, every task record only has the overall project and the immediate parent task (if any). To display full information, the code has to 'walk' up (or down) the tree following the trail and assemble the tree. It 's a bit inefficient, but it means that there is no limit...
-
Cloned Project Dates reset to 2010
-
Well, I spent a while looking for a bug, but there actually wasn't one. When you clone a project, you give a new deadline date, which is then set in the new project. To keep everything in order, the tasks are also shifted in date proportionally to the old and new dates. With your clone project the deadline is set to the year 2029. When you clone the project to current day, all the tasks are shifted by the difference of (2029 - 2020) years - or about 10 years. Shifting the clone projects to a more...
-
Can you show me the (basic) project template that you are using? I am not seeing this behaviour. Also, what database (type (mysql, postgres) and version) are you using? The date calculations are done within the database.
-
Mysql deployment error 1067 (42000) (solved)
-
Admin is a reserved word in MySQL 8
-
Fixed with release of version 3.50
-
work factor not set in config file
-
Resolved
-
The real question is why zero dates are being passed to the database. This code in time.php is intended to stop zero dates being passed to the database. //check for valid calendar date if( ! checkdate($month, $day, $year ) ) { warning($lang['invalid_date'], sprintf($lang['invalid_date_sprt'], safe_data($year.'-'.$month_array[$month ].'-'.$day ) ) ); } If the date is valid (non zero) the value is then formatted for the database: //format is 2004-08-02 00:00:00 // The hour is set to 2.00am (instead...
-
Thanks for the bug report. Are you saying that removing sql_mode "NO_ZERO_IN_DATE,NO_ZERO_DATE" solved the problem? If that fixes the problem, I guess the question is why there are zeros in the date.
-
Thanks Martin. I've just tested and all working fine. Well timed, I am trying to finalise a new release (Still testing and looking for bugs). I'll do an upload to Git tomorrow.
-
No, sorry, it looks like a network error. Error 504 is a gateway error that would be unrelated to WebCollab.
-
Fixed the encoding issue on fr_help.php. Removed the BOM (Byte order marker) from the begining of the file and all works. Uploaded to Git with thanks.
-
Martin, Thank you. I have just uploaded the three main language files to the Git Repository. I tested the fr_help.php file and my browser gave an error message about encoding, but my editor opens it fine. I'll have to do some more testing to work out what is happening here. Sometimes character encoding can get mixed up. I've had this before... By the way, there are three help files - one for admin, one for setup and the one that you have done. I've done a diff on the index.php file that you have...
-
Thank you. You are most welcome to post them here. I'll add them the Git repository here. All the released files have an email adress in them, but the paradise.net.nz domain disappeared last year, so you could try gmail with andrewnz.simpson (This is in git repository files too).
-
Small correction: The error message was added to version 3.41.
-
I'm not sure that you are running version 3.20, because that error message was added in about version 3.42. Are you using an old config file with a newer version? Anyway, try adding the following line to [webcollab]/config/config.php //Work factor for Blowfish password hashing (values are 4 to 31, for default use 8) define('WORK_FACTOR', 8 ); It can go anywhere in the file. That /should/ fix the problem.
-
O.K. here is the relevant code from file_submit.php //check the destination directory is writeable by the webserver if( ! is_writable(FILE_BASE.'/' ) ) { error('Configuration error', 'The upload directory does not have write permissions set properly, or the directory does not exist. File upload has not been accepted.'); } So, PHP cannot write to the directory at all. This won't be a setting in php.ini. It has to be a permissions problem. However, I see that you have made the directory world wwritable,...
-
Thank you for doing this. I've just tested and all looking fine. I will upload to Git shortly.
-
So, from what you have said there is a database connection and ordinary database queries are all being done. But prepared statements to the database are not working. Strange that one small component won't work, while the other related parts do. Can you turn on 'debugging' in the config file, before you run setup? That should give full error message when it fails. Hopefully there is something useful there. You could also try logging in with user / password as admin / admin123, but I think it may well...
-
Create README.md
-
Files affected are: /db/schema_mysql_innodb.sql /db/schema_pgsql.sql /icalendar/icalendar_login.php /includes/security.php /rss/rss_common.php /setup/setup_security.php /update.php /users/user_edit.php /users/user_show.php users/user_submit.php Upload to the git repository shortly. The update file will automatically make the database changes to existing databases.
-
Admin is a reserved word in MySQL 8
-
Project Cloning Bug
-
Thank you for reporting. I have not yet tested with MySQL 8, so I have not encountered this. I will go through and modify the code base. I think there might be more than just schema & security affected. When I've found all the affected files, I will list them here for convenience. I will do a new release too, but that will take a little longer. Much appreciated.
-
O.K. I can't find IE 8 or 10. IE 11 works fine, as does Chrome and Firefox. So, it appears to be browser related. I think it is most likely to be the browser redirect. Everything else is plain HTML. The line is: index.php header('Location: '.BASE_URL.'main.php' ); BASE_URL is set in config.php and is the absolute path. I am wondering if there is a browser setting to refuse redirections. WebCollab would have been used by many people over the years with IE 8 & 10 (with the redirect), so something has...
-
Can you login with other browsers? I've had no other reports of problems with IE8 & IE10. Webcollab does error checking all the way through the login process. You should be getting an error message if there is an internal error. I'll do a test on IE to be sure.
-
Since you are not getting error messages, this suggests that the connection to the ldap server is being made. There is an error check in WebCollab at this stage. The next stage is to set options. There is no error check for this, but I would be surprised if this is the problem. Final stage is to verify the password with ldap_bind. If this stage gives an error, or password fails, the login is refused without a detailed error message. It might be worth looking at this stage to try and see what is causing...
-
Yes, there are two settings for the locale. The config file will set the overall locale, but it can also be changed by each user. Go into 'user edit' and change the language to 'sr' (or whatever). When you create a user they should default to the locale in config. If that doesn't work, please let me know (May be a bug somewhere).
-
Interesting. The earlier version should have worked as well. As you can guess, PHP...
-
O.K. fixed in the Git Repository. You need to get the file [webcollab]/index.php...
-
Thanks. I am also getting this problem. This function was working previously so I...
-
There are several places that set the file upload limit - in WebCollab, the Apache...
-
Good point. At present it's hard coded in (to the code); there is no ability to bulk...
-
Good point. At present it's hard coded in (to the code); there is no ability to bilk...
-
Thanks. Hmmm... this thread was over two years old.
-
Very interesting. What you've done looks correct and it was working. Everything works...
-
Oh yes, WebCollab has a lot of error checking builtin - which you are now finding....
-
Do you want to disable these fields? Or, are you saying that the normal user can't...
-
Cynthia, Have a look a this page http://webcollab.sourceforge.net/faq.html#files...
-
If you would like to test the attached file that would be much appreciated. The file...
-
Nasty little bug! It doesn't show up until you have several layers under the project....
-
O.K. I have entered in the first 'phase' (CONCEPT PLAN) on my machine and that cloned...
-
Can you please confirm that CONCEPT PLAN, FIRST SUBMITTAL, SECOND SUBMITTAL, THE...
-
Interesting. After a bit of code tracing, it would appear that the problem occurs...
-
This is caused by WebCollab not being able to connect to the database. This can be...
1 >
