Mathias Gumz

https://github.com/fluxbox/fluxbox/tree/fix/dont-deliver-sigalarm will be merged as soon as some logistics are cleared. thanks for putting the attention on that patch.

infinite loop in Menu::cycleItems()

https://github.com/fluxbox/fluxbox/pull/70/commits/8a54c1ab241071fa1245b6f75a55b44bbfcb7d86

Good catch! For code clarity I would prefer an extra loop / check upfront if there is any selectable item anyways … similar to the m_items.empty() check. If you dont mind … I ll provide patch, towards github and will provide a thanks to your patch. But very good catch of the issue.

Yah, that's what I have found as well :) Which made me wonder in the first place on why the spec states that every element (as stored in the property) must contain the 0 byte … when existing utility functions already deal with the issue. The original spec (before 1.0) was refering to 0-separated strings … so, n 0-terminated strings for the names … and then represented by a 0-separated list of utf8-encoded strings inside of the property … which is exactly what Xutf8TextListToTextProperty is actually...

_NET_DISPLAY_NAMES does not null-terminate the last name.

https://github.com/fluxbox/fluxbox/commit/c49aa33171e53b5a182a497ea1e5cf29e4a2b831 i have fixed the issue in master; i am still a bit … unsure about the reasoning behind the spec and how the used xutf8* functions actually work.

This is a very interesting observation / problem. https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm46400537458592 """ _NET_DESKTOP_NAMES, UTF8_STRING[] The names of all virtual desktops. This is a list of NULL-terminated strings in UTF-8 encoding [UTF8]. This property MAY be changed by a Pager or the Window Manager at any time. """ I check lots of other WMs (openbox, awesome, pekwm, fvwm etc): all of them are sidestepping Xutf8TextListToTextProperty (which should turn a list of...