Menu

#30 broken exec svn calls on windows + patch

closed-fixed
nobody
None
5
2006-06-11
2005-09-17
Anonymous
No

Hello,
it seems the usage of the open3 in the Subversion.pm.new
should be different on windows.
When I try to use it as it is - I always get the "file
does not exist"
error.
This is because the $cmd includes both the command name
and the arguments.

Please find attached below the patch that fixes this
problem.

my env:
windows XP professional. SP1

codestriker 1.9.1

apache 2.0.54

perl --version

This is perl, v5.8.7 built for MSWin32-x86-multi-thread
(with 7 registered patches, see perl -V for more detail)

Copyright 1987-2005, Larry Wall

Binary build 813 [148120] provided by ActiveState
http://www.ActiveState.com
ActiveState is a division of Sophos.
Built Jun 6 2005 13:36:37

Perl may be copied only under the terms of either the
Artistic License or the
GNU General Public License, which may be found in the
Perl 5 source kit.

Discussion

  • Nobody/Anonymous

    patch to fix svn exec on windows

     
  • Kevin R. Priest

    Kevin R. Priest - 2005-10-27

    Logged In: YES
    user_id=1195911

    The patch solves my problem reported in the forum
    (https://sourceforge.net/forum/message.php?msg_id=3400099).
    However, I noticed a discrepancy among the three
    applications of the change. There are two instances of a
    change that looks like

    < my $pid = open3(...,$cmd);
    ---
    > my $pid = ...,$Codestriker::svn,$cmd);

    However, the first of the two changes in getDiff(), looks like

    < my $pid = open3(...,$cmd);
    ---
    > my $pid = ...,$Codestriker::svn);

    i.e., the $cmd is missing. Will this prevent using themodule
    name as a directory?

     
  • David Sitsky

    David Sitsky - 2006-06-11

    Logged In: YES
    user_id=208928

    Please try one of the 1.9.2 alpha releases. This is now
    done by calling open3 where args is a complete array, which
    is the best way of doing things, as it avoids shell quoting
    issues.

     
  • David Sitsky

    David Sitsky - 2006-06-11
    • status: open --> closed-fixed
     

Log in to post a comment.