Menu

#348 fixes bug 2821587

closed-fixed
None
2010-05-31
2010-05-04
oslsachem
No

Suggested attempt at fixing the bug. Please review carefully. :)

Discussion

  • oslsachem

    oslsachem - 2010-05-04

    Unfortunately it's the whole file, not a diff :(

     
  • Katie Russell

    Katie Russell - 2010-05-31

    I'm a bit confused. The file is cut off at line 110. The original file is a lot longer. Sorry but I can't do anything with this. A diff (cvs diff -uN) would be a lot better, but failing that please merge your changes with any others on CVS head and then resubmit. Thank you.

    http://stendhalgame.org/wiki/How_To_Create_Patch_For_Stendhal

     
  • Katie Russell

    Katie Russell - 2010-05-31
    • assigned_to: nobody --> kymara
    • status: open --> closed-fixed
     
  • Katie Russell

    Katie Russell - 2010-05-31

    Ok, I tried 3 more times and a full version did finally download!

    Thanks for submitting this patch.

    Applied with some changes:

    Your email address validator did not accept some valid email address like those with a ö so I used the existing simpler one checking for an @, a . and a length

    We don't want to fill the email address field with spam, either. So I removed that 'No Email' input into the text field, and removed the validators server side which force content of min length 6

     

Anonymous
Anonymous

Add attachments
Cancel