Menu

#19 Boolean.valueOf() is always weaved

open
nobody
None
5
2008-08-21
2008-08-21
Max Berger
No

Dear Retroweaver devs,

I recently discovered that Boolean.valueOf() is always weaved into Boolean_.valueOf(). This method is available since 1.4, and is weaved because retroweaver also supports 1.3 as target.

The target of our project is 1.4, and we would like to use retroweaver, ideally without the runtime (to just support basic features). The current solution is a patched retroweaver where I removed the valueOf() method from Boolean_ -> not a nice solution.

So would it be possible to weave only those functions which actually require weaving?

A possible solution may be (don't know if this works, as retroweaver itself is weaved) to add annotations to the Boolean_ (and other classes) which tell what java version has them, and only translate if target is less than the given version.

Max

Discussion

  • Max Berger

    Max Berger - 2008-08-21

    Logged In: YES
    user_id=99210
    Originator: YES

    This patch is a proof-of-concept to illustate the annotations idea - it is neither properly tested nor properly formatted, but it shows the idea and it "works-for-me"
    File Added: annotations.patch

     
  • Max Berger

    Max Berger - 2008-08-21

    proof-of-concept patch

     
  • Max Berger

    Max Berger - 2008-08-21

    Logged In: YES
    user_id=99210
    Originator: YES

    File Added: annotations.patch

     

Log in to post a comment.