Menu

#2461 (ok 2.11) Left frame shrinks on database change

2.10.2
fixed
None
1
2013-06-11
2007-07-03
No

If i change the database via drop down menu, the left frame gets smaller and smaller.
I found a solution in js/navigation.js.
Here's my patch for v2.10.2:

4a5
> var pma_navi_width_cookie;
52a54
> if (pma_navi_width < pma_navi_width_cookie) pma_navi_width = pma_navi_width_cookie;
80c82
< pma_navi_width = PMA_getCookie('pma_navi_width');
---
> pma_navi_width = pma_navi_width_cookie = PMA_getCookie('pma_navi_width');

Discussion

  • Christian Meisinger

    Logged In: YES
    user_id=54589
    Originator: YES

    i know this prevents changing width of the left navigation frame via mouse drag&drop

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-03

    Logged In: YES
    user_id=1383652
    Originator: NO

    yes, I also noticed this annoying behaviour but dragging the frame border is still a nice feature.

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-03

    Logged In: YES
    user_id=1383652
    Originator: NO

    Christian,
    I only have this issue when I use theme "Grid", not with pma211/trunk original theme. Can you confirm?

     
  • Christian Meisinger

    Logged In: YES
    user_id=54589
    Originator: YES

    i use 'grid', 'crimson-gray' and 'very small', with smaller font size.
    all 3 with firefox 2.0.0.4 and IE7.

    *testing* ... original theme looks ok.
    but i haven't used it for a long time.

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-04

    Logged In: YES
    user_id=1383652
    Originator: NO

    well,
    it seems only to occur when

    $cfg['LeftDisplayServers'] = true;

    (regardless of the chosen theme)

     
  • Marc Delisle

    Marc Delisle - 2007-07-07
    • summary: Left frame shrinks on database change --> Left frame shrinks on database change (some themes)
    • milestone: --> 2.10.2
     
  • Marc Delisle

    Marc Delisle - 2007-07-07

    Logged In: YES
    user_id=210714
    Originator: NO

    Hmm, with 2.10.2 I cannot reproduce this (tested with grid and crimson-gray). But I see the bug with the unreleased SynergyDolphin.

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-11

    Logged In: YES
    user_id=1383652
    Originator: NO

    in pma 2.11 it also happens when changing the db page :(
    (still working on a solution for theme grid...)

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-14

    Logged In: YES
    user_id=1383652
    Originator: NO

    here is how to reproduce with the original theme (trunk only):

    $cfg['LeftDisplayServers'] = 1;
    $cfg['DisplayServersList'] = 1;
    $cfg['LeftFrameLight'] = 1;

    (more than one server defined)

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-15

    Logged In: YES
    user_id=1383652
    Originator: NO

    fixed in "Grid" (at least if not $cfg['LeftDisplayServers'])
    see http://sf.net/support/tracker.php?aid=1656956

    <a href="http://sf.net/tracker/download.php?group_id=23067&amp;atid=689412&amp;file_id=237111&amp;aid=1656956">grid 2.11 Download</a>

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-15

    Logged In: YES
    user_id=1383652
    Originator: NO

    Christian could you plz check the new "Grid" version (posting a direct download link doesn't work here) see trk-themes link below or try and paste this into your browser url:
    http://sf.net/tracker/download.php?group_id=23067&atid=689412&file_id=237111&aid=1656956

     
  • Marc Delisle

    Marc Delisle - 2007-07-17

    Logged In: YES
    user_id=210714
    Originator: NO

    Juergen,
    with your post of 2007-07-14 17:46, I try with FF 2. If the database name to which I switch is shorter, the frame shrinks. If it's longer, the frame enlarges. It's not "the frame gets smaller and smaller".

     
  • Marc Delisle

    Marc Delisle - 2007-07-17
    • assigned_to: nobody --> lem9
     
  • Jürgen Wind

    Jürgen Wind - 2007-07-17

    Logged In: YES
    user_id=1383652
    Originator: NO

    Marc,
    I can only observe the "shrinking" effect but never saw an "enlarging" one.

    tested with:
    IE7, FF2004, SeaMonkey 1.2.2, Opera 9.02 (

    here on winXP,
    often on http://pma.cihar.com/trunk-config/ (2.11),
    sometimes on http://pma.cihar.com/TESTING/ (2.10.3)

    theme: original, Grid-2.10b (and maybe others)

    often reproducable *just after dragging the frame border*
    and reloading the navi frame
    (by or selecting a db or rightclick->frame->reload )

    ... still investigating ...

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-17

    Logged In: YES
    user_id=1383652
    Originator: NO

    something like this modification to js/navigation.js (line 56 ...)
    _____

    function PMA_saveFrameSizeReal()
    {
    if (parent.text_dir == 'ltr') {
    pma_navi_width = parseInt(parent.document.getElementById('mainFrameset').cols)
    } else {
    // todo: rtl
    pma_navi_width = document.getElementById('body_leftFrame').offsetWidth
    }
    ______

    seems to fix the quirk.
    offsetWidth is slightly different from the frame width.

     
  • Jürgen Wind

    Jürgen Wind - 2007-07-20

    Logged In: YES
    user_id=1383652
    Originator: NO

    here the complete modified function (in navigation.js) working for RTL languages as well:

    function PMA_saveFrameSizeReal()
    {
    if (parent.text_dir == 'ltr') {
    pma_navi_width = parseInt(parent.document.getElementById('mainFrameset').cols)
    } else {
    pma_navi_width = parent.document.getElementById('mainFrameset').cols.match(/\d+$/)
    }
    if ((pma_navi_width > 0)&&(pma_navi_width != PMA_getCookie('pma_navi_width'))) {
    PMA_setCookie('pma_navi_width', pma_navi_width, expires);
    }
    }

    there may exist more simple solutions though

     
  • Marc Delisle

    Marc Delisle - 2007-07-22

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged, thanks.

     
  • Marc Delisle

    Marc Delisle - 2007-07-22
    • priority: 5 --> 1
    • summary: Left frame shrinks on database change (some themes) --> (ok 2.11) Left frame shrinks on database change
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2007-08-21
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed