#337 Shouldn't trace lost connection at warning level
From Martin Scheffler starting at http://www.eros-os.org/pipermail/e-lang/2007-January/011803.html
At http://www.eros-os.org/pipermail/e-lang/2007-January/011808.html I respond
> About the killConnection warning:
> I knew about reactToLostClient and I used it already. I just wondered
> why I still got those trace messages. I searched through the E src and
> found the origin of the trace is in
> net.captp.jcomm.CapTPConnection.java.
> As far as I understand this trace is made on every disconnect, with
> "warning" level. So this is not an error in my program but just
> default behaviour.
Your analysis is correct. The relevant piece of code, in
src/jsrc/net/captp/jcomm/CapTPConnection.java, is
//at warning level because lost connections should be traced by
//default.
if (Trace.captp.warning && Trace.ON) {
Trace.captp.warningm("lost " + this, problem);
}
The comment records that I thought this was a good idea at the time, but I now
agree that that's not appropriate. I'll reduce it to a level that's not traced
by default. Thanks for reporting this!
Logged In: YES
user_id=54168
Originator: YES
Now always traced at debug level. Deliberate or not is now distinguished only by the traced text:
String prefix = deliberate ? "shutdown " : "lost ";
if (Trace.captp.debug && Trace.ON) {
Trace.captp.debugm(prefix + this, problem);
}