Menu

#314 (ok 2.9.0-beta2) layout.inc bugfix

Work_in_progress
closed-accepted
None
1
2006-08-27
2006-07-16
No

in themes/original/layout.inc.php

to restore the good old vertical line as handle for
dragging the frame border:

// background for the main frame
$GLOBALS['cfg']['MainBackground'] = '#F5F5F5
url(../' . $_SESSION['PMA_Theme']->getImgPath() .
'vertical_line.png) repeat-y';
(line 30)

Discussion

  • Jürgen Wind

    Jürgen Wind - 2006-07-16
    • milestone: --> Work_in_progress
    • summary: themes/original vertical_line as handle --> (HEAD) themes/original vertical_line as handle
     
  • Jürgen Wind

    Jürgen Wind - 2006-07-16
    • summary: (HEAD) themes/original vertical_line as handle --> (HEAD) themes/original vertical_line like 2.8.2
     
  • Sebastian Mendel

    • status: open --> pending-rejected
     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    this was dropped intentionally, 'original' should be as
    simple as possible

     
  • Jürgen Wind

    Jürgen Wind - 2006-08-05
    • summary: (HEAD) themes/original vertical_line like 2.8.2 --> (HEAD) layout.inc bugfix
    • status: pending-rejected --> open-remind
     
  • Jürgen Wind

    Jürgen Wind - 2006-08-05

    Logged In: YES
    user_id=1383652

    >should be as simple as possible
    OK, i agree
    but if someone likes the oldstyle and removes "//" before
    the second "$GLOBALS['cfg']['MainBackground']", he runs into
    trouble because
    "#F5F5F5 " before "uri"
    and
    " repeat-y" after "vertical_line.png)"
    are missing.
    That's what my initial post was all about (and why i got
    confused and tried to implement the vertical_line in
    css/theme_right.css.php, as posted some weeks ago)

    ----
    second:
    in the same file now

    /**
    * font size as a valid css font size value,
    * if not set the browser default will be used
    * (depending on browser, DTD and system settings)
    */
    $GLOBALS['cfg']['FontSize'] = '';

    as it is not evaluated as startup value.

    I think a "submit new" is not necessary, is it?

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    "missing vertical", aah, you are right ... but whgere is
    gone ... ?

    "as it is not evaluated as startup value." what do you mean
    with is not evaluated? where should it be evaluated?

     
  • Jürgen Wind

    Jürgen Wind - 2006-08-05

    Logged In: YES
    user_id=1383652

    it could be used(=evaluated) as a startup value, when no
    cookie is used yet instead of droping it at all.
    IMHO

     
  • Jürgen Wind

    Jürgen Wind - 2006-08-05

    Logged In: YES
    user_id=1383652

    rephrase:
    /**
    * font size as a valid css font size value,
    * if not set the browser default will be used
    * (depending on browser, DTD and system settings)
    */
    $GLOBALS['cfg']['FontSize'] = '';

    is not necessary any more, if you don't want to use it as
    startup value, when the cookie is not set yet.

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    yes, i know what you mean, i forgot it somehow, of course it
    should be used as the initial value in the selectbox ...

     
  • Marc Delisle

    Marc Delisle - 2006-08-27
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2006-08-27

    Logged In: YES
    user_id=210714

    Merged (in the commented line), thanks.

     
  • Marc Delisle

    Marc Delisle - 2006-08-27
    • summary: (HEAD) layout.inc bugfix --> (ok 2.9.0-beta2) layout.inc bugfix
    • priority: 5 --> 1
    • status: open-remind --> open-accepted
     
  • Jürgen Wind

    Jürgen Wind - 2006-08-27
    • status: open-accepted --> closed-accepted