Menu

#210 grip 3.1.2 crash if cddb lookup returns too many matches

Bug
closed-fixed
nobody
None
5
2005-06-25
2003-11-02
No

stack backtrace:

#0 0x08061c6e in DiscDBDoQuery (disc=0x41185008,
server=0x411f77f4,
hello=0x41a37c7c, query=0x41a373ec) at discdb.c:298
#1 0x08054b2e in DiscDBLookupDisc (ginfo=0x41185008,
server=0x411f77f4)
at cdplay.c:208
#2 0x080549a6 in DoLookup (data=0x41185008) at cdplay.c:165
#3 0x409f09b1 in pthread_start_thread () from
/lib/i686/libpthread.so.0
#4 0x40006e61 in open_path () from /lib/ld-linux.so.2

297 while((inbuffer=DiscDBReadLine(&result))) {
> crash here>>298
query->query_list[query->query_matches].list_genre=
299 DiscDBGenreValue(g_strstrip(strtok(inbuffer," ")));

print query->query_matches
$1 = 23
whatis query->query_list
type = struct query_list_entry [16]

apparently too many matching queries returned, which overflowed
the buffer.

work-around is to disable automatic cddb queries.

Discussion

  • Flammie Pirinen

    Flammie Pirinen - 2004-07-15

    Logged In: YES
    user_id=32570

    I can verify this with 3.2.0, the output of verbose goes as
    follows:
    ...
    Haku on [cddb+query+0e01fd02+2+150+21857+511]
    URI on
    http://freedb.freedb.org/~cddb/cddb.cgi?cmd=cddb+query+0e01fd02+2+150+21857+511&hello=private+free.the.cddb+Grip+3.2.0&proto=6
    ]211 Found inexact matches, list follows (until terminating `.')
    ]rock 1501f602 Whiteberry / YUKI
    ]rock 1401f602 遊佐未森 / 暮れてゆく空は
    ]rock 1001f602 Busta Rhymes ft/ Zhane / It's A Party (singles)
    ]soundtrack 1301f702 Various / People
    ]rock 0f01f702 Glenmark Eriksson Str mstedt / Fr n Dag Till
    Dag (CD Single)
    ]misc 1501f702 Dive / Ultralight Lovegun
    ]misc 1301f702 Eminem / The Real Slim Shady (Single)
    ]folk 1101f702 Felix McTeigue / Demo 2003
    ]reggae 1501f802 Iam / Petit Frre (Single)
    ]rock 1101f802 Ultramagnetic M.C.'s / Poppa Large
    ]misc 1301f802 del amitri / driving with the brakes on
    ]soundtrack 1001f902 Varios Artists / Kellog's Classic Rock
    ]misc 1201f902 Eddy Mitchell / un portait de Norman Rockwell
    ]rock 1201fa02 Lisa Stansfield / Never, Never Gonna Give You Up
    ]rock 0e01fa02 Allanah Myles / CD Single
    ...
    Bonobo accessibility support initialized
    GTK Accessibility Module initialized
    Atk Accessibilty bridge initialized
    bash- $

    This obviously mostly happens with CD Singles, so it's not
    too big of annoyance.

     
  • Mike Oliphant

    Mike Oliphant - 2005-06-25
    • status: open --> closed-fixed
     
  • Nobody/Anonymous

    Aloha! <a href="http://toolpyog.com">byhes gugpv</a>

     
  • Nobody/Anonymous

    of annoyance

     

Log in to post a comment.