Menu

#23 SuperAbbrevs tab-spaces emulation

closed
None
5
2008-05-31
2008-05-29
uudashr
No

The SuperAbbrevs template currently created using tab character for indentation. When the buffer options the tab is emulated using spaces, the inserted template doesn't doesn't change the tab character into spaces (if the tab to spaces enabled)

I've create simple patch on revision 12715 attached. By the way, the revision cannot be compiled, so I've test it using source distribution downloaded from the jedit plugins site.

Discussion

  • uudashr

    uudashr - 2008-05-29

    Patch file

     
  • Alan Ezust

    Alan Ezust - 2008-05-29

    Logged In: YES
    user_id=935841
    Originator: NO

    moving to the plugin patches tracker.

     
  • Alan Ezust

    Alan Ezust - 2008-05-29
    • assigned_to: nobody --> sune_simonsen
     
  • Nobody/Anonymous

    Logged In: NO

    Thank you very much, I will apply the patch this weekend.

    -- Sune Simonsen

     
  • Sune Simonsen

    Sune Simonsen - 2008-05-31

    Logged In: YES
    user_id=1316416
    Originator: NO

    There was a minor bug in the patch:
    The line:
    template.replaceAll("\t", spaces(tabSize));
    Had to be changed to:
    template = template.replaceAll("\t", spaces(tabSize));

    The patch is now applied and commited to SVN.
    I will pack a new version for release today, so
    i will be a part of the next plugin release.

    -- Sune Simonsen

     
  • Sune Simonsen

    Sune Simonsen - 2008-05-31
    • status: open --> closed
     
  • uudashr

    uudashr - 2008-06-02

    Logged In: YES
    user_id=1993574
    Originator: YES

    Sorry there is bug on the patch. I forgot to check the "template == null".
    File Added: SuperAbbrevs.diff

     
  • uudashr

    uudashr - 2008-06-02

    Update the diff

     
  • Sune Simonsen

    Sune Simonsen - 2008-06-02

    Logged In: YES
    user_id=1316416
    Originator: NO

    Thank you, its fixed now.

     

Log in to post a comment.