Menu

#83 \'undo\' doesn\'t remember individual fields changed

(v0.9--obsolete)
closed-fixed
None
6
2007-02-24
2006-11-10
No

i have entered three entries...

pub=a
pub=b
pub=c

if i change 'pub=a' to 'pub=q', it simply deletes what
has been entered into the pub field. it should
remember what was previously there, and put back
'pub=a'. it seems if i click undo again, it will
remember the 'a'.

if the string i enter is longer than 1 character, like
'pub=abcdef', and i hit undo, it will only take away 1
character, not the whole string. i think it should
take away the whole string.

this is true for all the string/text fields i tried.

Discussion

  • Mark Gibson

    Mark Gibson - 2006-11-10

    Logged In: YES
    user_id=422804

    this is really 2 items - the second one is defintely awkward
    - 2 solutions - either text doesnt go into the model/table
    until user hits enter tab or changes focus to another field
    - currently it goes in with every keystroke - thus every
    keystroke is an action

    or if its important to keep the keystrokes going in (which i
    dont think it is) then the edit manager could have some
    smarts about lumping transactions together for undo - i like
    the former better i think

    the first issue is interesting - you enter a, you delete a
    and have a blank, you enter q - so what you are saying is
    the blank should be somehow ignored as a valid undo state -
    i think this comes down to the same as the above issue and
    could be solved the same way - so yea these are the same now
    that i think about it

    yea undo is basically prompting a different way of dealing
    with free text fields - opinions?

     
  • Nicole Washington

    Logged In: YES
    user_id=1526943

    >either text doesnt go into the model/table
    >until user hits enter tab or changes focus to another field

    i like this solution. only have it go in after enter or
    focus change

    although, what will happen then if i don't change
    focus/press enter. will it undo the step before i even
    started entering text into the field? it should probably
    just return to the state before you started entering
    anything. one thing you could do is to write each character
    to the history, but overwrite the history with the complete
    string each time. so, if i typed a string "foo" it would
    write "f", then overwrite 'f' with "fo", followed by
    overwriting "fo" with "foo". would that be complicated?

     
  • Mark Gibson

    Mark Gibson - 2006-11-16
    • milestone: --> (v0.9--obsolete)
    • status: open --> closed-fixed
     
  • Suzanna Lewis

    Suzanna Lewis - 2007-02-24
    • assigned_to: nobody --> mgibson
    • summary: 'undo' doesn't remember individual fields changed --> \'undo\' doesn\'t remember individual fields changed
     

Log in to post a comment.