Menu ▾ ▴

#34 Fix for regression in SSDP code to send/receive messages ove

None
closed-accepted
Marcelo Roberto Jimenez
upnp (66)
5
2013-07-31
2010-09-10
Chandra
No

Hello,

Sending messages over UDP is broken in some Apple OSes
such as OS X and iOS. This might be broken in other OSes too but didn't
verify.

The fix is to modify the socket length argument of sendto to use the correct
sockaddr length depending on whether the socket is IPV4 or IPV6.

Also added some error checks and debugging related to the issue.

Note that this is similar to issue 2 from tracker id 3056713. The patch against the latest sources is attached.

Thanks,
Chandra

Discussion

  • Chandra

    Chandra - 2010-09-10
    • milestone: --> trunk
    • labels: --> upnp
     

  • Marcelo Roberto Jimenez

    Marcelo Roberto Jimenez - 2010-09-10
    • assigned_to: nobody --> mroberto
    • status: open --> closed-accepted
     

  • Marcelo Roberto Jimenez

    Marcelo Roberto Jimenez - 2010-09-10

    Nice catch!

    I just fixed the debug message:

    src/ssdp/ssdp_ctrlpt.c: In function ‘SearchByTarget’:
    src/ssdp/ssdp_ctrlpt.c:634: warning: format ‘%s’ expects type ‘char *’, but argument 6 has type ‘int’

    Thanks for using git to generate the patch!

    Regards,
    Marcelo.