Menu

#69 DVDB cover broken

closed-fixed
nobody
engines (42)
5
2008-02-11
2008-02-08
No

The cover of DVDB is still located at: http://www.dvdb.de/dvdpix/big/\(id).jpg and not http://www.dvdb.de/v1/dvdpix/big/35.jpg

In addition, the preg_match also do not work anymore, because the URL is given absolute instead of relative.

I suggest to use:

$GLOBALS['dvdbServer'] = 'http://www.dvdb.de';

For the cover:

if (preg_match('/<img.+?src=".*\/(dvdpix\/big\/.*?\.jpg)"/i', $resp['data'], $ary))
{
$data['coverurl'] = $dvdbServer.'/'.trim($ary[1]);
}

And add a "/v1/ to all other positions where $dvdbServer occurs, e.g.:

return $dvdbServer.'/v1/index.cfm?action=viewdetails&dvd_id='.$id;

(or use a new variable $dvdbCoverServer = 'http://www.dvdb.de';

A hotfix for VideoDB v2.5.0 is attached

Discussion

  • Stefan Geisseler

    Hotfix for VideoDB 2.5.0

     
  • andig

    andig - 2008-02-08

    Logged In: YES
    user_id=391980
    Originator: NO

    Stephan,

    could you provide a fix against current CVS? Would be glad to apply. Would also consider giving you CVS access to maintain the DVDB engine. If I'm unable to find a new maintainer, the engine will be removed from next releases.
    Would also need to have a test case (check /test directory in CVS) if we want this engine supported any longer.

    Cheers,
    Andi

     
  • Stefan Geisseler

    Hotfix for VideoDB 3.0.0b1

     
  • Stefan Geisseler

    Logged In: YES
    user_id=2003451
    Originator: YES

    When you want to add german DVD's, dvdb.de seems to be the best choice. You can even add DVD/HD DVD/Blueray using the barcode and get the right cover matching your version of the movie. Therefore this engine should stay in VideoDB. Here is a Hotfix for VideoDB 3.0.0b1.
    File Added: dvdb.php

     
  • Stefan Geisseler

    Logged In: YES
    user_id=2003451
    Originator: YES

    Hm, the latest CVS has changes there, and I like them more than my ones, so this is already fixed :-)
    But as long as there is no stable version, the hotfix should be nice for people with version 2.5.0 :-)

     
  • andig

    andig - 2008-02-11
    • status: open --> closed-fixed
     
  • andig

    andig - 2008-02-11

    Logged In: YES
    user_id=391980
    Originator: NO

    Closing as fixed.

     

Log in to post a comment.