Menu

#391 CUIWnd.h destructor

Latest Subversion
closed-fixed
Client (126)
1
2009-01-05
2009-01-05
Ondrej Riha
No

Class CUIWnd.h which is inherited by class FleetDetailWnd, IntroScreen and MapWndPopup does not have a virtual destructor.

Discussion

  • Ondrej Riha

    Ondrej Riha - 2009-01-05
    • priority: 5 --> 1
     
  • Ondrej Riha

    Ondrej Riha - 2009-01-05
     
  • Ondrej Riha

    Ondrej Riha - 2009-01-05

    Need to commit patch.

     
  • Ondrej Riha

    Ondrej Riha - 2009-01-05
    • assigned_to: nobody --> geoffthemedio
     
  • Geoff Topping

    Geoff Topping - 2009-01-05
    • status: open --> closed-fixed
     
  • Geoff Topping

    Geoff Topping - 2009-01-05

    Fixed in Subversion.

     
  • Geoff Topping

    Geoff Topping - 2009-01-05

    Since CUIWnd is derived from GG::Wnd, which has a virtual destructor, CUIWnd's destructor is also automatically virtual, even if not explicitly declared virtual, so this change was unnecessary (but harmless).

     

Log in to post a comment.