Menu

#105 Public header files should not include config.h.

closed-fixed
None
5
2007-11-09
2007-11-08
No

The public header files installed with the CinePaint library for plug-in development should not include the autoconf generated config.h header file since it inteferes with other use of autoconf generating warnings like these:

In file included from /usr/local/include/cinepaint/float16.h:22,
from /usr/local/include/cinepaint/plugin_main.h:29,
from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:144:1: warning: "PACKAGE" redefined
In file included from ufraw-gimp.c:19:
config.h:95:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/float16.h:22,
from /usr/local/include/cinepaint/plugin_main.h:29,
from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:164:1: warning: "VERSION" redefined
In file included from ufraw-gimp.c:19:
config.h:116:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/libgimp/gimpintl.h:28,
from /usr/local/include/cinepaint/intl.h:25,
from /usr/local/include/cinepaint/libgimp/gimp1.2.h:16,
from /usr/local/include/cinepaint/libgimp/gimp.h:14,
from /usr/local/include/cinepaint/plugin_main.h:32,
from ufraw-gimp.c:28:
./config.h:95:1: warning: "PACKAGE" redefined
In file included from /usr/local/include/cinepaint/float16.h:22,
from /usr/local/include/cinepaint/plugin_main.h:29,
from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:144:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/libgimp/gimpintl.h:28,
from /usr/local/include/cinepaint/intl.h:25,
from /usr/local/include/cinepaint/libgimp/gimp1.2.h:16,
from /usr/local/include/cinepaint/libgimp/gimp.h:14,
from /usr/local/include/cinepaint/plugin_main.h:32,
from ufraw-gimp.c:28:
./config.h:116:1: warning: "VERSION" redefined
In file included from /usr/local/include/cinepaint/float16.h:22,
from /usr/local/include/cinepaint/plugin_main.h:29,
from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:164:1: warning: this is the location of the previous definition

Currently (CinePaint 0.22-1) gimpintl.h and float16.h includes config.h.

Regards,
Niels Kristian

Discussion

  • Kai-Uwe Behrmann

    Logged In: YES
    user_id=634841
    Originator: NO

    a fix is in CVS

     
  • Kai-Uwe Behrmann

    • status: open --> open-fixed
     
  • Kai-Uwe Behrmann

    • assigned_to: nobody --> beku
     
  • Niels Kristian Bech Jensen

    Logged In: YES
    user_id=1306336
    Originator: YES

    Thanks.

     
  • Niels Kristian Bech Jensen

    • status: open-fixed --> closed-fixed
     

Log in to post a comment.