Menu

#45 [patch] selectBy(nonexistantcolumn=foo) passes silently

closed-accepted
None
5
2006-02-03
2006-02-02
No

When doing a query on a table, for instance:

Foo.selectBy(food="bar")

where 'food' is a typo, and 'foo' is the correct column
name, no error will occur, and this is equivilnet to:

Foo.select()

Attached is a patch to both dbconnection.py and
tests/test_select.py, adding an exception to the code
for the case where unexpected kwargs are passed, and a
test for that behaviour.

Discussion

  • Stephen Thorne

    Stephen Thorne - 2006-02-02

    selectBy(nonexistantcolumn='foo') fix

     
  • Oleg Broytman

    Oleg Broytman - 2006-02-03
    • assigned_to: nobody --> phd
    • status: open --> closed-accepted
     
  • Oleg Broytman

    Oleg Broytman - 2006-02-03

    Logged In: YES
    user_id=4799

    Applied to the revision 1560 to the trunk, r1561 to the
    0.7-branch. Thank you!

     

Log in to post a comment.